Issue 10382060: Unifies the two tab dragging variants. I would have liked to better

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10382060: Unifies the two tab dragging variants. I would have liked to better (Closed)

Created:
8 years, 7 months ago by sky

Modified:
8 years, 7 months ago

Reviewers:

CC:
chromium-reviews, dcheng

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Unifies the two tab dragging variants. I would have liked to better separate out the two, but it proved difficult to do since they require different setup and use. Also adds tests for the existing behavior (previously lacking) and nukes an existing test since it's covered by new tests and was mostly disabled. BUG=123274 TEST=none (covered by tests)

Patch Set 1 #

Created: 8 years, 7 months ago

Download [raw] [tar.bz2]

Unified diffs	Side-by-side diffs	Stats (+1204 lines, -5416 lines)			Patch
chrome/browser/ui/views/tabs/default_tab_drag_controller.h	View	1 chunk	+0 lines, -426 lines	0 comments	Download
chrome/browser/ui/views/tabs/default_tab_drag_controller.cc	View	1 chunk	+0 lines, -1642 lines	0 comments	Download
chrome/browser/ui/views/tabs/tab_drag_controller.h	View	12 chunks	+148 lines, -32 lines	0 comments	Download
chrome/browser/ui/views/tabs/tab_drag_controller.cc	View	57 chunks	+551 lines, -313 lines	0 comments	Download
chrome/browser/ui/views/tabs/tab_drag_controller2.h	View	1 chunk	+0 lines, -395 lines	0 comments	Download
chrome/browser/ui/views/tabs/tab_drag_controller2.cc	View	1 chunk	+0 lines, -1425 lines	0 comments	Download
chrome/browser/ui/views/tabs/tab_drag_controller2_interactive_uitest.cc	View	1 chunk	+0 lines, -605 lines	0 comments	Download
chrome/browser/ui/views/tabs/tab_drag_controller_interactive_uitest.h	View	1 chunk	+72 lines, -0 lines	0 comments	Download
chrome/browser/ui/views/tabs/tab_drag_controller_interactive_uitest.cc	View	15 chunks	+68 lines, -50 lines	0 comments	Download
chrome/browser/ui/views/tabs/tab_drag_controller_interactive_uitest_win.cc	View	1 chunk	+355 lines, -0 lines	0 comments	Download
chrome/browser/ui/views/tabs/tab_dragging_test.cc	View	1 chunk	+0 lines, -514 lines	0 comments	Download
chrome/browser/ui/views/tabs/tab_strip.h	View	1 chunk	+2 lines, -3 lines	0 comments	Download
chrome/browser/ui/views/tabs/tab_strip.cc	View	2 chunks	+4 lines, -3 lines	0 comments	Download
chrome/chrome_browser.gypi	View	2 chunks	+1 line, -4 lines	0 comments	Download
chrome/chrome_tests.gypi	View	3 chunks	+3 lines, -4 lines	0 comments	Download