Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(600)

Issue 10382060: Unifies the two tab dragging variants. I would have liked to better (Closed)

Created:
8 years, 7 months ago by sky
Modified:
8 years, 7 months ago
Reviewers:
CC:
chromium-reviews, dcheng
Visibility:
Public.

Description

Unifies the two tab dragging variants. I would have liked to better separate out the two, but it proved difficult to do since they require different setup and use. Also adds tests for the existing behavior (previously lacking) and nukes an existing test since it's covered by new tests and was mostly disabled. BUG=123274 TEST=none (covered by tests)

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1204 lines, -5416 lines) Patch
chrome/browser/ui/views/tabs/default_tab_drag_controller.h View 1 chunk +0 lines, -426 lines 0 comments Download
chrome/browser/ui/views/tabs/default_tab_drag_controller.cc View 1 chunk +0 lines, -1642 lines 0 comments Download
chrome/browser/ui/views/tabs/tab_drag_controller.h View 12 chunks +148 lines, -32 lines 0 comments Download
chrome/browser/ui/views/tabs/tab_drag_controller.cc View 57 chunks +551 lines, -313 lines 0 comments Download
chrome/browser/ui/views/tabs/tab_drag_controller2.h View 1 chunk +0 lines, -395 lines 0 comments Download
chrome/browser/ui/views/tabs/tab_drag_controller2.cc View 1 chunk +0 lines, -1425 lines 0 comments Download
chrome/browser/ui/views/tabs/tab_drag_controller2_interactive_uitest.cc View 1 chunk +0 lines, -605 lines 0 comments Download
chrome/browser/ui/views/tabs/tab_drag_controller_interactive_uitest.h View 1 chunk +72 lines, -0 lines 0 comments Download
chrome/browser/ui/views/tabs/tab_drag_controller_interactive_uitest.cc View 15 chunks +68 lines, -50 lines 0 comments Download
chrome/browser/ui/views/tabs/tab_drag_controller_interactive_uitest_win.cc View 1 chunk +355 lines, -0 lines 0 comments Download
chrome/browser/ui/views/tabs/tab_dragging_test.cc View 1 chunk +0 lines, -514 lines 0 comments Download
chrome/browser/ui/views/tabs/tab_strip.h View 1 chunk +2 lines, -3 lines 0 comments Download
chrome/browser/ui/views/tabs/tab_strip.cc View 2 chunks +4 lines, -3 lines 0 comments Download
chrome/chrome_browser.gypi View 2 chunks +1 line, -4 lines 0 comments Download
chrome/chrome_tests.gypi View 3 chunks +3 lines, -4 lines 0 comments Download

Powered by Google App Engine
This is Rietveld 408576698