Issue 10381117: Merge 136451 - Reland "linux: Fix grabs for popups belonging to ..."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10381117: Merge 136451 - Reland "linux: Fix grabs for popups belonging to ..." (Closed)

Created:
8 years, 7 months ago by Daniel Erat

Modified:
8 years, 7 months ago

Reviewers:
Daniel Erat

CC:
chromium-reviews, yusukes+watch_chromium.org, jam, penghuang+watch_chromium.org, joi+watch-content_chromium.org, darin-cc_chromium.org, James Su

Base URL:
svn://svn.chromium.org/chrome/branches/1084/src/

Visibility:
Public.

More Reviews

Description

Merge 136451 - Reland "linux: Fix grabs for popups belonging to ..." This relands r135966, which was reverted by r136293. By adding the popup to its parent's window group, the DevTools profiler heap snapshot combobox receives mouse input again. I'm still not sure why this is necessary. Original description: When displaying a popup for an inactive tab, grab input on behalf of the popup's window rather than its parent window. [snip obsolete, now-removed window group change] BUG=126296 TEST=manual: original test case is still fine; dev tool regression described in r136293 is gone Review URL: https://chromiumcodereview.appspot.com/10389080 TBR=derat@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=136648

Patch Set 1 #

Created: 8 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+30 lines, -17 lines)			Patch
	M	content/browser/renderer_host/render_widget_host_view_gtk.cc	View		1 chunk	+30 lines, -17 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

lgtm

Expand Messages | Collapse Messages