content/browser/renderer_host/render_view_host_impl.h - Issue 10381073: Revert 132407 - Fixing a problem, where a hung renderer process is not killed when navigating away

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/renderer_host/render_view_host_impl.h

Issue 10381073: Revert 132407 - Fixing a problem, where a hung renderer process is not killed when navigating away (Closed) Base URL: svn://svn.chromium.org/chrome/branches/1130/src/

Patch Set: Created 8 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/renderer_host/render_view_host_browsertest.cc ('k') | content/browser/renderer_host/render_view_host_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/renderer_host/render_view_host_impl.h

===================================================================

--- content/browser/renderer_host/render_view_host_impl.h (revision 136082)

+++ content/browser/renderer_host/render_view_host_impl.h (working copy)

@@ -291,9 +291,8 @@

// of the parameters.

void SwapOut(int new_render_process_host_id, int new_request_id);

- // Called by ResourceDispatcherHost after the SwapOutACK is received or the

- // response times out.

- void OnSwapOutACK(bool timed_out);

+ // Called by ResourceDispatcherHost after the SwapOutACK is received.

+ void OnSwapOutACK();

// Called to notify the renderer that it has been visibly swapped out and

// replaced by another RenderViewHost, after an earlier call to SwapOut.

@@ -590,9 +589,6 @@

// is_waiting_for_beforeunload_ack_, unload_ack_is_for_cross_site_transition_.

bool is_waiting_for_unload_ack_;

- // Set to true when waiting for ViewHostMsg_SwapOut_ACK has timed out.

- bool has_timed_out_on_unload_;

// Valid only when is_waiting_for_beforeunload_ack_ or

// is_waiting_for_unload_ack_ is true. This tells us if the unload request

// is for closing the entire tab ( = false), or only this RenderViewHost in