Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(193)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 10381073: Revert 132407 - Fixing a problem, where a hung renderer process is not killed when navigating away (Closed)

Created:
8 years, 7 months ago by Charlie Reis
Modified:
8 years, 7 months ago
Reviewers:
nasko
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam
Visibility:
Public.

Description

Revert 132407 - Fixing a problem, where a hung renderer process is not killed when navigating away BUG=104346 TEST=Steps to reproduce listed in the bug. Review URL: http://codereview.chromium.org/10065028 TBR=nasko@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=136086

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -343 lines) Patch
M content/browser/renderer_host/render_process_host_impl.h View 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/renderer_host/render_process_host_impl.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/renderer_host/render_view_host_browsertest.cc View 2 chunks +0 lines, -141 lines 0 comments Download
M content/browser/renderer_host/render_view_host_impl.h View 2 chunks +2 lines, -6 lines 0 comments Download
M content/browser/renderer_host/render_view_host_impl.cc View 12 chunks +3 lines, -73 lines 0 comments Download
M content/browser/renderer_host/render_widget_helper.h View 2 chunks +3 lines, -4 lines 0 comments Download
M content/browser/renderer_host/render_widget_helper.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_impl.h View 1 chunk +0 lines, -5 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_impl.cc View 3 chunks +4 lines, -8 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_unittest.cc View 1 chunk +0 lines, -17 lines 0 comments Download
M content/browser/renderer_host/resource_dispatcher_host_impl.h View 2 chunks +0 lines, -9 lines 0 comments Download
M content/browser/renderer_host/resource_dispatcher_host_impl.cc View 3 chunks +3 lines, -18 lines 0 comments Download
M content/browser/renderer_host/test_render_view_host.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/web_contents/render_view_host_manager.cc View 1 chunk +1 line, -3 lines 0 comments Download
M content/browser/web_contents/render_view_host_manager_unittest.cc View 5 chunks +5 lines, -5 lines 0 comments Download
M content/browser/web_contents/test_web_contents.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/public/browser/render_process_host.h View 1 chunk +2 lines, -1 line 0 comments Download
D content/test/data/english_page.html View 1 chunk +0 lines, -7 lines 0 comments Download
D content/test/data/infinite_beforeunload.html View 1 chunk +0 lines, -17 lines 0 comments Download
D content/test/data/infinite_unload.html View 1 chunk +0 lines, -17 lines 0 comments Download
M content/test/mock_render_process_host.h View 1 chunk +1 line, -1 line 0 comments Download
M content/test/mock_render_process_host.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
Charlie Reis
8 years, 7 months ago (2012-05-09 18:41:21 UTC) #1
nasko
8 years, 7 months ago (2012-05-09 18:54:39 UTC) #2 
lgtm

Powered by Google App Engine
This is Rietveld 408576698