Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(705)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: src/trusted/validator_arm/inst_classes_testers.h

Issue 10381030: Clean up testing of instructions. Allow testing to quit if test pattern tests (Closed) Base URL: svn://svn.chromium.org/native_client/trunk/src/native_client/
Patch Set: Created 8 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/trusted/validator_arm/gen/arm32_decode_tests.cc ('k') | src/trusted/validator_arm/inst_classes_testers.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/trusted/validator_arm/inst_classes_testers.h
===================================================================
--- src/trusted/validator_arm/inst_classes_testers.h (revision 8517)
+++ src/trusted/validator_arm/inst_classes_testers.h (working copy)
@@ -32,7 +32,7 @@
public:
explicit Unary1RegisterImmediateOpTester(
const NamedClassDecoder& decoder);
- virtual void ApplySanityChecks(nacl_arm_dec::Instruction inst,
+ virtual bool ApplySanityChecks(nacl_arm_dec::Instruction inst,
const NamedClassDecoder& decoder);
private:
@@ -46,7 +46,7 @@
public:
explicit Unary1RegisterImmediateOpTesterRegsNotPc(
const NamedClassDecoder& decoder);
- virtual void ApplySanityChecks(
+ virtual bool ApplySanityChecks(
nacl_arm_dec::Instruction inst,
const NamedClassDecoder& decoder);
@@ -68,7 +68,7 @@
public:
explicit BinaryRegisterImmediateTestTester(
const NamedClassDecoder& decoder);
- virtual void ApplySanityChecks(nacl_arm_dec::Instruction inst,
+ virtual bool ApplySanityChecks(nacl_arm_dec::Instruction inst,
const NamedClassDecoder& decoder);
private:
@@ -90,7 +90,7 @@
public:
explicit Unary2RegisterOpTester(
const NamedClassDecoder& decoder);
- virtual void ApplySanityChecks(
+ virtual bool ApplySanityChecks(
nacl_arm_dec::Instruction inst,
const NamedClassDecoder& decoder);
@@ -104,7 +104,7 @@
public:
explicit Unary2RegisterOpTesterNotRdIsPcAndS(
const NamedClassDecoder& decoder);
- virtual void ApplySanityChecks(
+ virtual bool ApplySanityChecks(
nacl_arm_dec::Instruction inst,
const NamedClassDecoder& decoder);
@@ -127,7 +127,7 @@
public:
explicit Binary2RegisterImmediateOpTester(
const NamedClassDecoder& decoder);
- virtual void ApplySanityChecks(
+ virtual bool ApplySanityChecks(
nacl_arm_dec::Instruction inst,
const NamedClassDecoder& decoder);
@@ -146,7 +146,7 @@
public:
Binary2RegisterImmediateOpTesterNotRdIsPcAndS(
const NamedClassDecoder& decoder);
- virtual void ApplySanityChecks(nacl_arm_dec::Instruction inst,
+ virtual bool ApplySanityChecks(nacl_arm_dec::Instruction inst,
const NamedClassDecoder& decoder);
private:
@@ -183,7 +183,7 @@
public:
explicit Binary3RegisterOpTester(
const NamedClassDecoder& decoder);
- virtual void ApplySanityChecks(
+ virtual bool ApplySanityChecks(
nacl_arm_dec::Instruction inst,
const NamedClassDecoder& decoder);
@@ -198,7 +198,7 @@
public:
explicit Binary3RegisterOpTesterRegsNotPc(
const NamedClassDecoder& decoder);
- virtual void ApplySanityChecks(
+ virtual bool ApplySanityChecks(
nacl_arm_dec::Instruction inst,
const NamedClassDecoder& decoder);
@@ -221,7 +221,7 @@
public:
explicit Unary2RegisterImmedShiftedOpTester(
const NamedClassDecoder& decoder);
- virtual void ApplySanityChecks(
+ virtual bool ApplySanityChecks(
nacl_arm_dec::Instruction inst,
const NamedClassDecoder& decoder);
@@ -236,7 +236,7 @@
public:
explicit Unary2RegisterImmedShiftedOpTesterImm5NotZero(
const NamedClassDecoder& decoder);
- virtual void ApplySanityChecks(
+ virtual bool ApplySanityChecks(
nacl_arm_dec::Instruction inst,
const NamedClassDecoder& decoder);
@@ -251,7 +251,7 @@
public:
explicit Unary2RegisterImmedShiftedOpTesterNotRdIsPcAndS(
const NamedClassDecoder& decoder);
- virtual void ApplySanityChecks(
+ virtual bool ApplySanityChecks(
nacl_arm_dec::Instruction inst,
const NamedClassDecoder& decoder);
@@ -277,7 +277,7 @@
public:
explicit Unary3RegisterShiftedOpTester(
const NamedClassDecoder& decoder);
- virtual void ApplySanityChecks(
+ virtual bool ApplySanityChecks(
nacl_arm_dec::Instruction inst,
const NamedClassDecoder& decoder);
@@ -292,7 +292,7 @@
public:
explicit Unary3RegisterShiftedOpTesterRegsNotPc(
const NamedClassDecoder& decoder);
- virtual void ApplySanityChecks(
+ virtual bool ApplySanityChecks(
nacl_arm_dec::Instruction inst,
const NamedClassDecoder& decoder);
@@ -316,7 +316,7 @@
public:
explicit Binary3RegisterImmedShiftedOpTester(
const NamedClassDecoder& decoder);
- virtual void ApplySanityChecks(
+ virtual bool ApplySanityChecks(
nacl_arm_dec::Instruction inst,
const NamedClassDecoder& decoder);
@@ -331,7 +331,7 @@
public:
explicit Binary3RegisterImmedShiftedOpTesterNotRdIsPcAndS(
const NamedClassDecoder& decoder);
- virtual void ApplySanityChecks(
+ virtual bool ApplySanityChecks(
nacl_arm_dec::Instruction inst,
const NamedClassDecoder& decoder);
@@ -347,7 +347,7 @@
public:
explicit Binary3RegisterImmedShiftedOpTesterNotRdIsPcAndSOrRnIsSp(
const NamedClassDecoder& decoder);
- virtual void ApplySanityChecks(
+ virtual bool ApplySanityChecks(
nacl_arm_dec::Instruction inst,
const NamedClassDecoder& decoder);
@@ -374,7 +374,7 @@
public:
explicit Binary4RegisterShiftedOpTester(
const NamedClassDecoder &decoder);
- virtual void ApplySanityChecks(
+ virtual bool ApplySanityChecks(
nacl_arm_dec::Instruction inst,
const NamedClassDecoder& decoder);
@@ -390,7 +390,7 @@
public:
explicit Binary4RegisterShiftedOpTesterRegsNotPc(
const NamedClassDecoder &decoder);
- virtual void ApplySanityChecks(
+ virtual bool ApplySanityChecks(
nacl_arm_dec::Instruction inst,
const NamedClassDecoder& decoder);
@@ -413,7 +413,7 @@
public:
explicit Binary2RegisterImmedShiftedTestTester(
const NamedClassDecoder& decoder);
- virtual void ApplySanityChecks(
+ virtual bool ApplySanityChecks(
nacl_arm_dec::Instruction inst,
const NamedClassDecoder& decoder);
@@ -438,7 +438,7 @@
public:
explicit Binary3RegisterShiftedTestTester(
const NamedClassDecoder& decoder);
- virtual void ApplySanityChecks(
+ virtual bool ApplySanityChecks(
nacl_arm_dec::Instruction inst,
const NamedClassDecoder& decoder);
@@ -453,7 +453,7 @@
public:
explicit Binary3RegisterShiftedTestTesterRegsNotPc(
const NamedClassDecoder& decoder);
- virtual void ApplySanityChecks(
+ virtual bool ApplySanityChecks(
nacl_arm_dec::Instruction inst,
const NamedClassDecoder& decoder);
« no previous file with comments | « src/trusted/validator_arm/gen/arm32_decode_tests.cc ('k') | src/trusted/validator_arm/inst_classes_testers.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698