Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(748)

Unified Diff: src/trusted/validator_arm/decoder_tester.cc

Issue 10381030: Clean up testing of instructions. Allow testing to quit if test pattern tests (Closed) Base URL: svn://svn.chromium.org/native_client/trunk/src/native_client/
Patch Set: Created 8 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/trusted/validator_arm/decoder_tester.h ('k') | src/trusted/validator_arm/gen/arm32_decode.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/trusted/validator_arm/decoder_tester.cc
===================================================================
--- src/trusted/validator_arm/decoder_tester.cc (revision 8517)
+++ src/trusted/validator_arm/decoder_tester.cc (working copy)
@@ -27,12 +27,15 @@
DecoderTester::DecoderTester()
{}
-void DecoderTester::ApplySanityChecks(Instruction inst,
+bool DecoderTester::ApplySanityChecks(Instruction inst,
const NamedClassDecoder& decoder) {
UNREFERENCED_PARAMETER(inst);
- EXPECT_EQ(&decoder, &ExpectedDecoder())
+ bool test = (&decoder == &ExpectedDecoder());
+ EXPECT_TRUE(test)
<< "Expected " << ExpectedDecoder().name() << " but found "
<< decoder.name() << " for " << InstContents();
+ NC_PRECOND(test);
+ return true;
}
void DecoderTester::TestAtIndex(int index) {
« no previous file with comments | « src/trusted/validator_arm/decoder_tester.h ('k') | src/trusted/validator_arm/gen/arm32_decode.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698