Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(923)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: src/trusted/validator_arm/actual_vs_baseline.cc

Issue 10381030: Clean up testing of instructions. Allow testing to quit if test pattern tests (Closed) Base URL: svn://svn.chromium.org/native_client/trunk/src/native_client/
Patch Set: Created 8 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/trusted/validator_arm/actual_vs_baseline.h ('k') | src/trusted/validator_arm/armv7.table » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/trusted/validator_arm/actual_vs_baseline.cc
===================================================================
--- src/trusted/validator_arm/actual_vs_baseline.cc (revision 8517)
+++ src/trusted/validator_arm/actual_vs_baseline.cc (working copy)
@@ -44,12 +44,13 @@
CheckSetsZIfBitsClear();
}
-void ActualVsBaselineTester::ApplySanityChecks(
+bool ActualVsBaselineTester::ApplySanityChecks(
nacl_arm_dec::Instruction inst,
const NamedClassDecoder& decoder) {
UNREFERENCED_PARAMETER(inst);
UNREFERENCED_PARAMETER(decoder);
- GTEST_FAIL() << "Sanity Checks shouldn't be applied!";
+ EXPECT_TRUE(false) << "Sanity Checks shouldn't be applied!";
+ return false;
}
const NamedClassDecoder& ActualVsBaselineTester::ExpectedDecoder() const {
« no previous file with comments | « src/trusted/validator_arm/actual_vs_baseline.h ('k') | src/trusted/validator_arm/armv7.table » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698