src/trusted/validator_arm/actual_classes.h - Issue 10381030: Clean up testing of instructions. Allow testing to quit if test pattern tests

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/trusted/validator_arm/actual_classes.h

Issue 10381030: Clean up testing of instructions. Allow testing to quit if test pattern tests (Closed) Base URL: svn://svn.chromium.org/native_client/trunk/src/native_client/

Patch Set: Created 8 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/trusted/validator_arm/actual_classes.h

===================================================================

--- src/trusted/validator_arm/actual_classes.h (revision 8517)

+++ src/trusted/validator_arm/actual_classes.h (working copy)

@@ -260,11 +260,12 @@

inline ImmediateBic() {}

virtual ~ImmediateBic() {}

+ // TODO(karl) Determine why we ever allowed BIC to directly write PC.

// ImmediateBic is exempted from the writes-r15 check.

- virtual SafetyLevel safety(Instruction i) const {

- UNREFERENCED_PARAMETER(i);

- return MAY_BE_SAFE;

- }

+ // virtual SafetyLevel safety(Instruction i) const {

+ // UNREFERENCED_PARAMETER(i);

+ // return MAY_BE_SAFE;

+ // }

virtual bool clears_bits(Instruction i, uint32_t mask) const;

private:

« no previous file with comments | « no previous file | src/trusted/validator_arm/actual_vs_baseline.h » ('j') | no next file with comments »