chrome/browser/ui/views/js_modal_dialog_views.cc - Issue 10378086: views: Add a new ctor to MessageBoxView that takes only a InitParams.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/js_modal_dialog_views.cc

Issue 10378086: views: Add a new ctor to MessageBoxView that takes only a InitParams. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: fix review Created 8 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/views/js_modal_dialog_views.cc

diff --git a/chrome/browser/ui/views/js_modal_dialog_views.cc b/chrome/browser/ui/views/js_modal_dialog_views.cc

index 813d9a70e5d8c9c9793dd2718fe5b72a478db33a..e3e1c5eadb7734e7a6b44d02cd27118f110fc366 100644

--- a/chrome/browser/ui/views/js_modal_dialog_views.cc

+++ b/chrome/browser/ui/views/js_modal_dialog_views.cc

@@ -22,9 +22,10 @@ JSModalDialogViews::JSModalDialogViews(JavaScriptAppModalDialog* parent)

if (parent->javascript_message_type() == ui::JAVASCRIPT_MESSAGE_TYPE_PROMPT)

options |= views::MessageBoxView::HAS_PROMPT_FIELD;

- message_box_view_ = new views::MessageBoxView(options,

- parent->message_text(),

- parent->default_prompt_text());

+ views::MessageBoxView::InitParams params(parent->message_text());

+ params.options = options;

+ params.default_prompt = parent->default_prompt_text();

+ message_box_view_ = new views::MessageBoxView(params);

DCHECK(message_box_view_);

message_box_view_->AddAccelerator(