chrome/browser/ui/views/external_protocol_dialog.cc - Issue 10378086: views: Add a new ctor to MessageBoxView that takes only a InitParams.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/external_protocol_dialog.cc

Issue 10378086: views: Add a new ctor to MessageBoxView that takes only a InitParams. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: fix review Created 8 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/views/external_protocol_dialog.cc

diff --git a/chrome/browser/ui/views/external_protocol_dialog.cc b/chrome/browser/ui/views/external_protocol_dialog.cc

index 101d0a9f5396acdd0c5a04045749c7630dfbd6a6..988542ff5e03e017c5be2e48b5d942c93b230175 100644

--- a/chrome/browser/ui/views/external_protocol_dialog.cc

+++ b/chrome/browser/ui/views/external_protocol_dialog.cc

@@ -147,11 +147,9 @@ ExternalProtocolDialog::ExternalProtocolDialog(WebContents* web_contents,

message_text += l10n_util::GetStringUTF16(IDS_EXTERNAL_PROTOCOL_WARNING);

- message_box_view_ = new views::MessageBoxView(

- views::MessageBoxView::NO_OPTIONS,

- message_text,

- string16(),

- kMessageWidth);

+ views::MessageBoxView::InitParams params(message_text);

+ params.message_width = kMessageWidth;

+ message_box_view_ = new views::MessageBoxView(params);

message_box_view_->SetCheckBoxLabel(

l10n_util::GetStringUTF16(IDS_EXTERNAL_PROTOCOL_CHECKBOX_TEXT));