Issue 10378043: Allow the RWHVW to be focused when a window is restored from minimized.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10378043: Allow the RWHVW to be focused when a window is restored from minimized. (Closed)

Created:
8 years, 7 months ago by Ben Goodger (Google)

Modified:
8 years, 7 months ago

Reviewers:
sky

CC:
chromium-reviews, yusukes+watch_chromium.org, ben+watch_chromium.org, tfarina, jam, penghuang+watch_chromium.org, joi+watch-content_chromium.org, darin-cc_chromium.org, James Su

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

This restores a hack that was in place in the old NativeTabContentsContainer code that seemed to clear focus during restoration (though the hack was for another purpose, the hack seemed to fix this bug too). I've isolated the hack to the re-activation code. http://crbug.com/125976 TEST=see bug Review URL: https://chromiumcodereview.appspot.com/10378043 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=137040 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=137153

Patch Set 1 : #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : #

Patch Set 6 : #

Patch Set 7 : #

Created: 8 years, 7 months ago

Download [raw] [tar.bz2]

Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+132 lines, -81 lines)			Patch
chrome/browser/ui/views/accessibility_event_router_views_unittest.cc	View	1 2 3 4 5 6	5 chunks	+19 lines, -2 lines	0 comments	Download
ui/base/test/dummy_input_method.h	View	1 2 3 4 5 6	1 chunk	+19 lines, -30 lines	0 comments	Download
ui/base/test/dummy_input_method.cc	View	1 2 3 4 5 6	1 chunk	+70 lines, -0 lines	0 comments	Download
ui/ui_unittests.gypi	View	1 2 3 4 5 6	2 chunks	+3 lines, -7 lines	0 comments	Download
ui/views/accessible_pane_view_unittest.cc	View	1 2 3 4 5 6	4 chunks	+4 lines, -1 line	0 comments	Download
ui/views/test/views_test_base.cc	View	1 2 3 4 5 6	2 chunks	+2 lines, -41 lines	0 comments	Download
ui/views/views.gyp	View	1 2 3 4 5 6	1 chunk	+1 line, -0 lines	0 comments	Download
ui/views/widget/native_widget_win.cc	View	1 2 3 4 5 6	3 chunks	+14 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ben@chromium.org/10378043/16002

8 years, 7 months ago (2012-05-14 23:26:00 UTC) #3

Change committed as 137040

Expand Messages | Collapse Messages