chrome/browser/history/expire_history_backend_unittest.cc - Issue 10378009: Get rid of Image::Image(SkBitmap*)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/history/expire_history_backend_unittest.cc

Issue 10378009: Get rid of Image::Image(SkBitmap*) (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Patch Created 8 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/history/expire_history_backend_unittest.cc

diff --git a/chrome/browser/history/expire_history_backend_unittest.cc b/chrome/browser/history/expire_history_backend_unittest.cc

index fffc7f1103c76804398b5fabf42ae768033a456a..40562e1ca3dc3abb5cecf056cc8af4bbcb34bbe5 100644

--- a/chrome/browser/history/expire_history_backend_unittest.cc

+++ b/chrome/browser/history/expire_history_backend_unittest.cc

@@ -230,8 +230,9 @@ void ExpireHistoryTest::AddExampleData(URLID url_ids[3], Time visit_times[4]) {

thumb_db_->AddIconMapping(url_row3.url(), favicon2);

// Thumbnails for each URL. |thumbnail| takes ownership of decoded SkBitmap.

- gfx::Image thumbnail(

+ scoped_ptr<SkBitmap> thumbnail_bitmap(

gfx::JPEGCodec::Decode(kGoogleThumbnail, sizeof(kGoogleThumbnail)));

+ gfx::Image thumbnail(*thumbnail_bitmap);

ThumbnailScore score(0.25, true, true, Time::Now());

Time time;