chrome/browser/favicon/favicon_tab_helper.cc - Issue 10378009: Get rid of Image::Image(SkBitmap*)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/favicon/favicon_tab_helper.cc

Issue 10378009: Get rid of Image::Image(SkBitmap*) (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Patch Created 8 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/favicon/favicon_tab_helper.cc

diff --git a/chrome/browser/favicon/favicon_tab_helper.cc b/chrome/browser/favicon/favicon_tab_helper.cc

index 2d7cda3b639142e26202cdeb40c831298f45972c..3aac80f244612e1391703d46d3e5c9e6abbb0472 100644

--- a/chrome/browser/favicon/favicon_tab_helper.cc

+++ b/chrome/browser/favicon/favicon_tab_helper.cc

@@ -186,7 +186,7 @@ void FaviconTabHelper::OnDidDownloadFavicon(int id,

const GURL& image_url,

bool errored,

const SkBitmap& image) {

- gfx::Image favicon(new SkBitmap(image));

+ gfx::Image favicon(image);

favicon_handler_->OnDidDownloadFavicon(id, image_url, errored, favicon);

if (touch_icon_handler_.get())

touch_icon_handler_->OnDidDownloadFavicon(id, image_url, errored, favicon);