chrome/browser/tab_contents/thumbnail_generator.cc - Issue 10378009: Get rid of Image::Image(SkBitmap*)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/tab_contents/thumbnail_generator.cc

Issue 10378009: Get rid of Image::Image(SkBitmap*) (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: k Created 8 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/tab_contents/thumbnail_generator.cc

diff --git a/chrome/browser/tab_contents/thumbnail_generator.cc b/chrome/browser/tab_contents/thumbnail_generator.cc

index c8678d11e90273128ce4494e7ef476af29abcae0..1834ae748f43b2c278159a99e2bbaa658389e92c 100644

--- a/chrome/browser/tab_contents/thumbnail_generator.cc

+++ b/chrome/browser/tab_contents/thumbnail_generator.cc

@@ -471,7 +471,7 @@ void ThumbnailGenerator::UpdateThumbnail(

clip_result == ThumbnailGenerator::kNotClipped);

score.load_completed = (!load_interrupted_ && !web_contents->IsLoading());

- gfx::Image image(new SkBitmap(thumbnail));

+ gfx::Image image(thumbnail);

const GURL& url = web_contents->GetURL();

top_sites->SetPageThumbnail(url, &image, score);

VLOG(1) << "Thumbnail taken for " << url << ": " << score.ToString();