Issue 10377180: Fix uninitialized member in ctor.

Issue 10377180: Fix uninitialized member in ctor. (Closed)

Created:
8 years, 7 months ago by groby-ooo-7-16

Modified:
8 years, 7 months ago

Reviewers:
James Hawkins

CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, jochen+watch-content_chromium.org

Base URL:
http://git.chromium.org/chromium/src.git@master

Visibility:
Public.

More Reviews

Description

Fix uninitialized member in ctor. TBR=darin@chromium.org R=jhawkins@chromium.org BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=137606

Patch Set 2 : Fix review nit. #

Created: 8 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -2 lines)			Patch
	M	content/browser/intents/internal_web_intents_dispatcher_unittest.cc	View		1 chunk	+3 lines, -2 lines	0 comments	Download
	M	webkit/glue/web_intent_reply_data.h	View	1	1 chunk	+3 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

groby-ooo-7-16

jhawkins: Please review darin: TBR'd for trivial webkit/glue change.

8 years, 7 months ago (2012-05-16 23:16:21 UTC) #1

James Hawkins

LGTM with nit. https://chromiumcodereview.appspot.com/10377180/diff/1/webkit/glue/web_intent_reply_data.h File webkit/glue/web_intent_reply_data.h (right): https://chromiumcodereview.appspot.com/10377180/diff/1/webkit/glue/web_intent_reply_data.h#newcode28 webkit/glue/web_intent_reply_data.h:28: WEB_INTENT_REPLY_INVALID, nit: This should be the ...

8 years, 7 months ago (2012-05-16 23:18:31 UTC) #2

groby-ooo-7-16

https://chromiumcodereview.appspot.com/10377180/diff/1/webkit/glue/web_intent_reply_data.h File webkit/glue/web_intent_reply_data.h (right): https://chromiumcodereview.appspot.com/10377180/diff/1/webkit/glue/web_intent_reply_data.h#newcode28 webkit/glue/web_intent_reply_data.h:28: WEB_INTENT_REPLY_INVALID, On 2012/05/16 23:18:31, James Hawkins wrote: > nit: ...

8 years, 7 months ago (2012-05-16 23:52:02 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/groby@chromium.org/10377180/5001

8 years, 7 months ago (2012-05-16 23:52:21 UTC) #4

Change committed as 137606

Expand Messages | Collapse Messages