Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(180)

Side by Side Diff: webkit/glue/web_intent_reply_data.h

Issue 10377180: Fix uninitialized member in ctor. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Created 8 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « content/browser/intents/internal_web_intents_dispatcher_unittest.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef WEBKIT_GLUE_WEB_INTENT_REPLY_DATA_H_ 5 #ifndef WEBKIT_GLUE_WEB_INTENT_REPLY_DATA_H_
6 #define WEBKIT_GLUE_WEB_INTENT_REPLY_DATA_H_ 6 #define WEBKIT_GLUE_WEB_INTENT_REPLY_DATA_H_
7 7
8 #include "base/string16.h" 8 #include "base/string16.h"
9 9
10 namespace webkit_glue { 10 namespace webkit_glue {
11 11
12 // Constant values use to indicate what type of reply the caller is getting from 12 // Constant values use to indicate what type of reply the caller is getting from
13 // the web intents service page. 13 // the web intents service page.
14 enum WebIntentReplyType { 14 enum WebIntentReplyType {
15 // Sent for a reply message (success). 15 // Sent for a reply message (success).
16 WEB_INTENT_REPLY_SUCCESS, 16 WEB_INTENT_REPLY_SUCCESS,
17 17
18 // Sent for a failure message. 18 // Sent for a failure message.
19 WEB_INTENT_REPLY_FAILURE, 19 WEB_INTENT_REPLY_FAILURE,
20 20
21 // Sent if the picker is cancelled without a selection being made. 21 // Sent if the picker is cancelled without a selection being made.
22 WEB_INTENT_PICKER_CANCELLED, 22 WEB_INTENT_PICKER_CANCELLED,
23 23
24 // Sent if the service contents is closed without any response being sent. 24 // Sent if the service contents is closed without any response being sent.
25 WEB_INTENT_SERVICE_CONTENTS_CLOSED, 25 WEB_INTENT_SERVICE_CONTENTS_CLOSED,
26
27 // Invalid type. Use to initialize reply types.
28 WEB_INTENT_REPLY_INVALID,
James Hawkins 2012/05/16 23:18:31 nit: This should be the first type, so that if the
groby-ooo-7-16 2012/05/16 23:52:02 Done.
26 }; 29 };
27 30
28 } // namespace webkit_glue 31 } // namespace webkit_glue
29 32
30 #endif // WEBKIT_GLUE_WEB_INTENT_REPLY_DATA_H_ 33 #endif // WEBKIT_GLUE_WEB_INTENT_REPLY_DATA_H_
OLDNEW
« no previous file with comments | « content/browser/intents/internal_web_intents_dispatcher_unittest.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698