Issue 10375033: Fix unsigned-Smi check in MappedArgumentsLookup

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10375033: Fix unsigned-Smi check in MappedArgumentsLookup (Closed)

Created:
8 years, 7 months ago by Jakob Kummerow

Modified:
8 years, 7 months ago

Reviewers:
danno

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Fix unsigned-Smi check in MappedArgumentsLookup BUG=126414 TEST=mjsunit/regress/regress-crbug-126414 Committed: https://code.google.com/p/v8/source/detail?r=11518

Patch Set 1 #

Total comments: 1

Created: 8 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+36 lines, -4 lines)			Patch
M	src/arm/ic-arm.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/ia32/ic-ia32.cc	View	2 chunks	+2 lines, -2 lines	1 comment	Download
M	src/mips/ic-mips.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
A	test/mjsunit/regress/regress-crbug-126414.js	View	1 chunk	+32 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Jakob Kummerow

PTAL. https://chromiumcodereview.appspot.com/10375033/diff/1/src/ia32/ic-ia32.cc File src/ia32/ic-ia32.cc (right): https://chromiumcodereview.appspot.com/10375033/diff/1/src/ia32/ic-ia32.cc#newcode399 src/ia32/ic-ia32.cc:399: __ j(above_equal, unmapped_case); With the fixed positive-smi check ...

8 years, 7 months ago (2012-05-07 09:17:02 UTC) #1

lgtm

Expand Messages | Collapse Messages