src/mips/ic-mips.cc - Issue 10375033: Fix unsigned-Smi check in MappedArgumentsLookup

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/mips/ic-mips.cc

Issue 10375033: Fix unsigned-Smi check in MappedArgumentsLookup (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Created 8 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/mips/ic-mips.cc

diff --git a/src/mips/ic-mips.cc b/src/mips/ic-mips.cc

index aba71af8877f2942a67b7bf8f95a61a867e6d9c5..964a7e2430d50305d2f0bbf30b6d4235626c46c5 100644

--- a/src/mips/ic-mips.cc

+++ b/src/mips/ic-mips.cc

@@ -767,7 +767,7 @@ static MemOperand GenerateMappedArgumentsLookup(MacroAssembler* masm,

__ Branch(slow_case, lt, scratch2, Operand(FIRST_JS_RECEIVER_TYPE));

// Check that the key is a positive smi.

- __ And(scratch1, key, Operand(0x8000001));

+ __ And(scratch1, key, Operand(0x80000001));

__ Branch(slow_case, ne, scratch1, Operand(zero_reg));

// Load the elements into scratch1 and check its map.