Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1420)

Unified Diff: src/trusted/validator_arm/validator.cc

Issue 10356115: Clean up code to clarify we are only tracking the condition flags of APSR. (Closed) Base URL: svn://svn.chromium.org/native_client/trunk/src/native_client/
Patch Set: Created 8 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/trusted/validator_arm/validator.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/trusted/validator_arm/validator.cc
===================================================================
--- src/trusted/validator_arm/validator.cc (revision 8588)
+++ src/trusted/validator_arm/validator.cc (working copy)
@@ -15,7 +15,7 @@
using nacl_arm_dec::Register;
using nacl_arm_dec::RegisterList;
using nacl_arm_dec::kRegisterNone;
-using nacl_arm_dec::kRegisterFlags;
+using nacl_arm_dec::kConditions;
using nacl_arm_dec::kRegisterPc;
using nacl_arm_dec::kRegisterLink;
@@ -70,7 +70,7 @@
if (first.defines(second.base_address_register())
&& first.clears_bits(sfi.data_address_mask())
- && !first.defs()[kRegisterFlags]
+ && !first.defs()[kConditions]
&& first.always_precedes(second)) {
return PATTERN_SAFE_2;
}
« no previous file with comments | « src/trusted/validator_arm/validator.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698