Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(82)

Unified Diff: src/trusted/validator_arm/validator.h

Issue 10356115: Clean up code to clarify we are only tracking the condition flags of APSR. (Closed) Base URL: svn://svn.chromium.org/native_client/trunk/src/native_client/
Patch Set: Created 8 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« src/trusted/validator_arm/model.h ('K') | « src/trusted/validator_arm/model.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/trusted/validator_arm/validator.h
===================================================================
--- src/trusted/validator_arm/validator.h (revision 8564)
+++ src/trusted/validator_arm/validator.h (working copy)
@@ -228,7 +228,7 @@
*/
bool always_follows(const DecodedInstruction &other) const {
return inst_.condition() == other.inst_.condition()
- && !other.defines(nacl_arm_dec::kRegisterFlags);
+ && !other.defines(nacl_arm_dec::kConditions);
}
/*
@@ -239,7 +239,7 @@
bool is_conditional_on(const DecodedInstruction &other) const {
return inst_.condition() == nacl_arm_dec::Instruction::EQ
&& other.inst_.condition() == nacl_arm_dec::Instruction::AL
- && other.defines(nacl_arm_dec::kRegisterFlags);
+ && other.defines(nacl_arm_dec::kConditions);
}
// The methods below mirror those on ClassDecoder, but are cached and cheap.
« src/trusted/validator_arm/model.h ('K') | « src/trusted/validator_arm/model.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698