Issue 10356059: Merge 135882 - [cros] Show release notes in app window + restore sesssion.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10356059: Merge 135882 - [cros] Show release notes in app window + restore sesssion. (Closed)

Created:
8 years, 7 months ago by Nikita (slow)

Modified:
8 years, 7 months ago

Reviewers:
Nikita (slow)

CC:
chromium-reviews, stevenjb+watch_chromium.org, nkostylev+watch_chromium.org, davemoore+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/branches/1084/src/

Visibility:
Public.

More Reviews

Description

Merge 135882 - [cros] Show release notes in app window + restore sesssion. This covers special case of "Release notes" in ChromeOS. All existing users would be shown new Getting Started Guide in app window in addition to their restored session when they would sign in after next update. Just passing --app=[GSG URL] is not enough as session would not be restored. Also using --app-restore-session + chrome://newtab for new user case so that user won't end up with empty desktop after closing GSG window. Not adding --app-restore-session switch to ChromeOS only switches so that it won't complicate BrowserInit code with ifdefs. BUG=126098, 1260025 TEST=Manual. Sign in with existing user after update and see GSG in app window + restored session. Review URL: https://chromiumcodereview.appspot.com/10332024 TBR=nkostylev@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=135897

Patch Set 1 #

Created: 8 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+28 lines, -4 lines)			Patch
M	chrome/browser/chromeos/login/existing_user_controller.cc	View	3 chunks	+6 lines, -3 lines	0 comments	Download
M	chrome/browser/defaults.h	View	1 chunk	+5 lines, -0 lines	0 comments	Download
M	chrome/browser/defaults.cc	View	1 chunk	+6 lines, -0 lines	0 comments	Download
M	chrome/browser/ui/browser_init.cc	View	2 chunks	+11 lines, -1 line	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages