[cros] Show release notes in app window + restore sesssion.

[cros] Show release notes in app window + restore sesssion.

This covers special case of "Release notes" in ChromeOS.
All existing users would be shown new Getting Started Guide in app window in addition to their restored session when they would sign in after next update.
Just passing --app=[GSG URL] is not enough as session would not be restored.

Also using --app-restore-session + chrome://newtab for new user case so that user won't end up with empty desktop after closing GSG window.

Not adding --app-restore-session switch to ChromeOS only switches so that it won't complicate BrowserInit code with ifdefs.

BUG=126098, 1260025
TEST=Manual. Sign in with existing user after update and see GSG in app window + restored session.

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=135882

[Nikita (slow), 2012-05-05 11:14:18]

dpolukhin@ - please review whole CL.

sky@ - please review browser_init.cc

[Nikita (slow), 2012-05-05 12:17:00]

Updated description + addressed case for ChromeOS new user:
open NTP in the background & focus GSG so that when latter is closed user won't
end up with empty desktop.

Dmitry suggested adding a custom flag --welcome-app=<url> that would expand into
--app=<url>
--app-restore-session

but I didn't find a code in Chrome which provides such switch expansion except
some tests. I think we're not using this pattern. Scott, please advice if
there's a place to handle such switch mapping.

[sky, 2012-05-07 04:30:41]

Could you clarify what exactly it is you're trying to add?

Thanks,

  -Scott

[sky, 2012-05-07 22:56:44]

On 2012/05/07 04:30:41, sky wrote:
> Could you clarify what exactly it is you're trying to add?
> 
> Thanks,
> 
>   -Scott

Ed stopped by and clarified what you're after.

  -Scott

[sky, 2012-05-07 22:58:26]

http://codereview.chromium.org/10332024/diff/8001/chrome/common/chrome_switch...
File chrome/common/chrome_switches.cc (right):

http://codereview.chromium.org/10332024/diff/8001/chrome/common/chrome_switch...
chrome/common/chrome_switches.cc:67: const char kAppRestoreSession[]            
= "app-restore-session";
I suspect we would always want this set for chromeos. I would rather see this
expressed as a browser_default that is always true for chromeos.

[Nikita (slow), 2012-05-08 08:47:58]

Scott, please take a look, removed flag, added const to browser_defaults
instead.

http://codereview.chromium.org/10332024/diff/8001/chrome/common/chrome_switch...
File chrome/common/chrome_switches.cc (right):

http://codereview.chromium.org/10332024/diff/8001/chrome/common/chrome_switch...
chrome/common/chrome_switches.cc:67: const char kAppRestoreSession[]            
= "app-restore-session";
On 2012/05/07 22:58:26, sky wrote:
> I suspect we would always want this set for chromeos. I would rather see this
> expressed as a browser_default that is always true for chromeos.

Done.

[sky, 2012-05-08 15:42:40]

LGTM

[commit-bot: I haz the power, 2012-05-08 17:47:10]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/nkostylev@chromium.org/10332024/13001