Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(864)

Unified Diff: content/browser/renderer_host/render_widget_host_view_aura.cc

Issue 10352016: Consolidate RenderWidgetHost::CopyFromBackingStore and RenderWidgetHost::AsyncCopyFromBackingStore. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebase Created 8 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/renderer_host/render_widget_host_view_aura.cc
diff --git a/content/browser/renderer_host/render_widget_host_view_aura.cc b/content/browser/renderer_host/render_widget_host_view_aura.cc
index 8e2aa2554e9aaa37c01fc2edddf4cc50ba93486f..c59820481eb54630f4ff0de4bce2fc20dce3cf27 100644
--- a/content/browser/renderer_host/render_widget_host_view_aura.cc
+++ b/content/browser/renderer_host/render_widget_host_view_aura.cc
@@ -424,34 +424,7 @@ BackingStore* RenderWidgetHostViewAura::AllocBackingStore(
return new BackingStoreSkia(host_, size);
}
-bool RenderWidgetHostViewAura::CopyFromCompositingSurface(
- const gfx::Size& size,
- skia::PlatformCanvas* output) {
- ui::Compositor* compositor = GetCompositor();
- if (!compositor)
- return false;
-
- ImageTransportClient* container = image_transport_clients_[current_surface_];
- if (!container)
- return false;
-
- if (!output->initialize(size.width(), size.height(), true))
- return false;
-
- ImageTransportFactory* factory = ImageTransportFactory::GetInstance();
- content::GLHelper* gl_helper = factory->GetGLHelper(compositor);
- if (!gl_helper)
- return false;
-
- unsigned char* addr = static_cast<unsigned char*>(
- output->getTopDevice()->accessBitmap(true).getPixels());
- return gl_helper->CopyTextureTo(container->texture_id(),
- container->size(),
- size,
- addr);
-}
-
-void RenderWidgetHostViewAura::AsyncCopyFromCompositingSurface(
+void RenderWidgetHostViewAura::CopyFromCompositingSurface(
const gfx::Size& size,
skia::PlatformCanvas* output,
base::Callback<void(bool)> callback) {
@@ -472,9 +445,9 @@ void RenderWidgetHostViewAura::AsyncCopyFromCompositingSurface(
if (!gl_helper)
return;
- scoped_callback_runner.Release();
unsigned char* addr = static_cast<unsigned char*>(
output->getTopDevice()->accessBitmap(true).getPixels());
+ scoped_callback_runner.Release();
gl_helper->AsyncCopyTextureTo(container->texture_id(),
container->size(),
size,

Powered by Google App Engine
This is Rietveld 408576698