Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(150)

Issue 10352016: Consolidate RenderWidgetHost::CopyFromBackingStore and RenderWidgetHost::AsyncCopyFromBackingStore. (Closed)

Created:
8 years, 7 months ago by mazda
Modified:
8 years, 7 months ago
Reviewers:
brettw
CC:
chromium-reviews, Avi (use Gerrit), mihaip-chromium-reviews_chromium.org, creis+watch_chromium.org, yusukes+watch_chromium.org, brettw-cc_chromium.org, jam, penghuang+watch_chromium.org, joi+watch-content_chromium.org, Aaron Boodman, darin-cc_chromium.org, ajwong+watch_chromium.org, James Su
Visibility:
Public.

Description

Consolidate RenderWidgetHost::CopyFromBackingStore and RenderWidgetHost::AsyncCopyFromBackingStore. This CL depends on http://codereview.chromium.org/10348007/. BUG=120003 TEST=Manual Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=135839

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Patch Set 4 : '' #

Patch Set 5 : '' #

Patch Set 6 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+54 lines, -159 lines) Patch
M chrome/browser/extensions/extension_tabs_module.cc View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/tab_contents/thumbnail_generator.cc View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/render_widget_host_impl.h View 1 chunk +1 line, -4 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_impl.cc View 2 chunks +4 lines, -31 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_aura.h View 1 2 3 4 5 1 chunk +1 line, -4 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_aura.cc View 1 2 3 4 5 2 chunks +2 lines, -29 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_gtk.h View 1 chunk +1 line, -4 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_gtk.cc View 1 2 3 4 5 1 chunk +1 line, -9 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_mac.h View 1 chunk +1 line, -4 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_mac.mm View 1 2 2 chunks +11 lines, -15 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_win.h View 1 2 3 4 5 1 chunk +1 line, -4 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_win.cc View 1 2 3 4 5 1 chunk +11 lines, -14 lines 0 comments Download
M content/browser/renderer_host/test_render_view_host.h View 1 chunk +1 line, -4 lines 0 comments Download
M content/browser/renderer_host/test_render_view_host.cc View 1 chunk +1 line, -7 lines 0 comments Download
M content/port/browser/render_widget_host_view_port.h View 1 2 3 4 1 chunk +4 lines, -8 lines 0 comments Download
M content/public/browser/render_widget_host.h View 1 2 3 1 chunk +12 lines, -20 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
mazda
Could you review this change?
8 years, 7 months ago (2012-05-06 04:06:57 UTC) #1
brettw
lgtm
8 years, 7 months ago (2012-05-07 22:22:57 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mazda@chromium.org/10352016/10002
8 years, 7 months ago (2012-05-08 04:54:09 UTC) #3
commit-bot: I haz the power
8 years, 7 months ago (2012-05-08 09:59:47 UTC) #4
Try job failure for 10352016-10002 (retry) (retry) on win_rel for step
"browser_tests".
It's a second try, previously, step "browser_tests" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

Powered by Google App Engine
This is Rietveld 408576698