Issue 10350013: Don't allow targeted navigations across BrowsingInstances.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10350013: Don't allow targeted navigations across BrowsingInstances. (Closed)

Created:
8 years, 7 months ago by Charlie Reis

Modified:
8 years, 7 months ago

Reviewers:
darin (slow to review)

CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Don't allow targeted navigations across BrowsingInstances. BUG=126174 TEST=Click a target=foo link again after a WebUI nav in the new window. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=135370

Patch Set 1 #

Created: 8 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+16 lines, -4 lines)			Patch
M	content/browser/renderer_host/render_view_host_impl.cc	View	2 chunks	+3 lines, -1 line	0 comments	Download
M	content/browser/web_contents/web_contents_impl.h	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	content/browser/web_contents/web_contents_impl.cc	View	1 chunk	+9 lines, -1 line	0 comments	Download
M	content/public/browser/render_view_host_delegate.h	View	1 chunk	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Charlie Reis

Darin, can you take a look? This adjusts what I added in http://codereview.chromium.org/9706047/ so that ...

8 years, 7 months ago (2012-05-03 21:39:49 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/creis@chromium.org/10350013/1

8 years, 7 months ago (2012-05-04 16:39:01 UTC) #3

commit-bot: I haz the power

8 years, 7 months ago (2012-05-04 17:05:24 UTC) #4

Try job failure for 10350013-1 (retry) (retry) on win for step "runhooks".
It's a second try, previously, step "runhooks" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win&number...

Expand Messages | Collapse Messages