Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1119)

Unified Diff: content/browser/renderer_host/render_view_host_impl.cc

Issue 10350013: Don't allow targeted navigations across BrowsingInstances. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | content/browser/web_contents/web_contents_impl.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/renderer_host/render_view_host_impl.cc
diff --git a/content/browser/renderer_host/render_view_host_impl.cc b/content/browser/renderer_host/render_view_host_impl.cc
index 919aee0e996b8ac5ed85280e1dbd940ca10be62d..5296ddb48df28d872a772990b354d39c05b83826 100644
--- a/content/browser/renderer_host/render_view_host_impl.cc
+++ b/content/browser/renderer_host/render_view_host_impl.cc
@@ -1258,7 +1258,7 @@ void RenderViewHostImpl::OnMsgOpenURL(const GURL& url,
GetProcess()->GetID(), false, &validated_url);
delegate_->RequestOpenURL(
- validated_url, referrer, disposition, source_frame_id);
+ this, validated_url, referrer, disposition, source_frame_id);
}
void RenderViewHostImpl::OnMsgDidContentsPreferredSizeChange(
@@ -1475,6 +1475,8 @@ bool RenderViewHostImpl::IsFullscreen() const {
}
void RenderViewHostImpl::OnMsgFocus() {
+ // Note: We allow focus and blur from swapped out RenderViewHosts, even when
+ // the active RenderViewHost is in a different BrowsingInstance (e.g., WebUI).
delegate_->Activate();
}
« no previous file with comments | « no previous file | content/browser/web_contents/web_contents_impl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698