Issue 10344028: Support cross-process window.close() messages.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10344028: Support cross-process window.close() messages. (Closed)

Created:
8 years, 7 months ago by Charlie Reis

Modified:
8 years, 7 months ago

Reviewers:
jam, Matt Perry

CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Support cross-process window.close() messages. BUG=99202 TEST=Call w.close() on a window that has opened but navigated cross-process. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=135416

Created: 8 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+61 lines, -1 line)			Patch
M	chrome/test/data/click-noreferrer-links.html	View	1 chunk	+8 lines, -0 lines	0 comments	Download
M	content/browser/renderer_host/render_view_host_impl.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	content/browser/renderer_host/render_view_host_impl.cc	View	2 chunks	+7 lines, -0 lines	0 comments	Download
M	content/browser/renderer_host/render_view_host_manager_browsertest.cc	View	2 chunks	+17 lines, -1 line	0 comments	Download
M	content/browser/web_contents/web_contents_impl.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	content/browser/web_contents/web_contents_impl.cc	View	1 chunk	+10 lines, -0 lines	0 comments	Download
M	content/common/swapped_out_messages.cc	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	content/common/view_messages.h	View	1 chunk	+4 lines, -0 lines	0 comments	Download
M	content/public/browser/render_view_host_delegate.h	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	content/renderer/render_widget.cc	View	1 chunk	+8 lines, -0 lines	0 comments	Download

Total messages: 4 (0 generated)

Charlie Reis

Now that the window opener CL has landed, we can start supporting cross-process JavaScript interactions ...

8 years, 7 months ago (2012-05-03 21:13:38 UTC) #1

Charlie Reis

Thanks! John, can you take a look for owner's approval?

8 years, 7 months ago (2012-05-04 16:43:43 UTC) #3

lgtm