Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(298)

Issue 10344016: Fix the implementation order of GeolocationProvider methods (Closed)

Created:
8 years, 7 months ago by bartfab (slow)
Modified:
8 years, 7 months ago
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Fix the implementation order of GeolocationProvider methods The GeolocationProvider methods are implemented in more-or-less random order. This CL arranges them so that they follow the order in the header file. This CL depends on https://chromiumcodereview.appspot.com/10344004/ BUG=chromium-os:18710 TEST=unit_tests, content_unittests Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=135337

Patch Set 1 : Method reordering patch. #

Patch Set 2 : Rebased. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+84 lines, -84 lines) Patch
M content/browser/geolocation/geolocation_provider.cc View 1 5 chunks +84 lines, -84 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
bartfab (slow)
Hi Jonathan, John, Marcus, Could one of you please review this CL? It fixes up ...
8 years, 7 months ago (2012-05-03 08:47:05 UTC) #1
John Knottenbelt
lgtm
8 years, 7 months ago (2012-05-04 10:35:22 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bartfab@chromium.org/10344016/5001
8 years, 7 months ago (2012-05-04 13:05:48 UTC) #3
commit-bot: I haz the power
8 years, 7 months ago (2012-05-04 14:28:13 UTC) #4
Change committed as 135337

Powered by Google App Engine
This is Rietveld 408576698