Use worker pool for IO in JsonPrefStore.

Use worker pool for IO in JsonPrefStore.

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=135222

[Sergey Ulanov, 2012-05-02 20:44:30]

Need this before I can land http://codereview.chromium.org/10291011/

[jam, 2012-05-02 22:12:39]

I haven't touched those files, can you find who wrote them and send to them?

[Sergey Ulanov, 2012-05-02 22:34:14]

On 2012/05/02 22:12:39, John Abd-El-Malek wrote:
> I haven't touched those files, can you find who wrote them and send to them?

I don't know who was original author of JsonPerfStore. The history goes back to
the initial open-source chromium release. Since then it was moved and refactored
multiple times by many people (originally it was part of
chrome/common/pref_service.cc). So I'm not sure who would be the right person to
review it. In either case the changes are rather trivial, so I don't think it
requires any special expertise to review this code.

+Paweł who wrote ImportantFileWriter.

[jam, 2012-05-03 06:10:33]

it's more that I'm heavily overloaded with reviews, so I prefer not to review
any files that I'm not familiar with. Any changes which just require any
committer to review should be sent elsewhere to split the review load a bit.

[Sergey Ulanov, 2012-05-03 17:58:54]

+brettw
Brett, since you are the author of SequencedWorkerPool, will you be able to
review this change?

[brettw, 2012-05-03 20:46:12]

lgtm

http://codereview.chromium.org/10344007/diff/1/chrome/common/json_pref_store.cc
File chrome/common/json_pref_store.cc (right):

http://codereview.chromium.org/10344007/diff/1/chrome/common/json_pref_store....
chrome/common/json_pref_store.cc:343: 
You added blank lines to the bottom of some of the files (a previous one as
well)

[Sergey Ulanov, 2012-05-03 20:56:48]

http://codereview.chromium.org/10344007/diff/1/chrome/common/json_pref_store.cc
File chrome/common/json_pref_store.cc (right):

http://codereview.chromium.org/10344007/diff/1/chrome/common/json_pref_store....
chrome/common/json_pref_store.cc:343: 
On 2012/05/03 20:46:22, brettw wrote:
> You added blank lines to the bottom of some of the files (a previous one as
> well)

Added it in attempt to workaround git-cl-upload not cooperating when uploading
this CL. will make sure I don't check it in. Thanks!

[commit-bot: I haz the power, 2012-05-03 21:01:38]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/sergeyu@chromium.org/10344007/11002

[commit-bot: I haz the power, 2012-05-03 21:57:18]

Try job failure for 10344007-11002 (retry) on win_rel for step "update" (clobber
build).
It's a second try, previously, step "compile" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

Step "update" is always a major failure.
Look at the try server FAQ for more details.