Retrieving Chrome Variations seed from server and storing in local prefs. Loading seed data from lo…

chrome/browser/chrome_browser_main.h

Index: chrome/browser/chrome_browser_main.h
diff --git a/chrome/browser/chrome_browser_main.h b/chrome/browser/chrome_browser_main.h
index fb67705eb5541696ad4446e74ff517b399d924ba..285167e2fd92480ffb04cf47fb8b99623ed6d8e3 100644
--- a/chrome/browser/chrome_browser_main.h
+++ b/chrome/browser/chrome_browser_main.h
@@ -30,6 +30,7 @@ class Profile;
 class StartupTimeBomb;
 class ShutdownWatcherHelper;
 class TranslateManager;
+class VariationsService;
 
 namespace chrome_browser {
 // For use by ShowMissingLocaleMessageBox.
@@ -211,11 +212,15 @@ class ChromeBrowserMainParts : public content::BrowserMainParts {
   // Members needed across shutdown methods.
   bool restart_last_session_;
 
+  // Initialized in SetupMetricsAndFieldTrials.
+  scoped_ptr<VariationsService> variations_service_;

[Ilya Sherman, 2012/05/02 23:15:08]

nit: Can this be a member of the MetricsService instead?  ChromeBrowserMain is
already ginormous -- it would be nice not to add to the problem :)

[SteveT, 2012/05/03 04:02:52]

I'm not super familiar with BrowserProcess vs BrowserMainParts, so this question
can help us figure out if this should go here: Why did you choose to have the
VariationService live here and not in the BrowserProcess, where MetricsService
live? Is it because we want a lifespan similar to FieldTrialList?

[jwd, 2012/05/03 22:27:49]

I put it here because I was modeling it after the TranslateManager. I will look
into putting it in MetricsService instead or somewhere else.
On 2012/05/03 04:02:52, SteveT wrote:

+
   // Tests can set this to true to disable restricting cookie access in the
   // network stack, as this can only be done once.
   static bool disable_enforcing_cookie_policies_for_tests_;
 
   friend class BrowserMainTest;
+
   FRIEND_TEST_ALL_PREFIXES(BrowserMainTest,
                            WarmConnectionFieldTrial_WarmestSocket);
   FRIEND_TEST_ALL_PREFIXES(BrowserMainTest, WarmConnectionFieldTrial_Random);