Retrieving Chrome Variations seed from server and storing in local prefs. Loading seed data from lo…

chrome/browser/chrome_browser_main.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_CHROME_BROWSER_MAIN_H_
 #define CHROME_BROWSER_CHROME_BROWSER_MAIN_H_
 #pragma once
 
 #include "base/basictypes.h"
 #include "base/gtest_prod_util.h"
@@ skipping 12 matching lines @@
 class BrowserProcessImpl;
 class ChromeBrowserMainExtraParts;
 class FieldTrialSynchronizer;
 class HistogramSynchronizer;
 class MetricsService;
 class PrefService;
 class Profile;
 class StartupTimeBomb;
 class ShutdownWatcherHelper;
 class TranslateManager;
+class VariationsService;
 
 namespace chrome_browser {
 // For use by ShowMissingLocaleMessageBox.
 extern const char kMissingLocaleDataTitle[];
 extern const char kMissingLocaleDataMessage[];
 }
 
 namespace chrome_browser_metrics {
 class TrackingSynchronizer;
 }
@@ skipping 161 matching lines @@
   // Members initialized in PreMainMessageLoopRun, needed in
   // PreMainMessageLoopRunThreadsCreated.
   bool is_first_run_;
   bool first_run_ui_bypass_;
   PrefService* local_state_;
   FilePath user_data_dir_;
 
   // Members needed across shutdown methods.
   bool restart_last_session_;
 
+  // Initialized in SetupMetricsAndFieldTrials.
+  scoped_ptr<VariationsService> variations_service_;

[Ilya Sherman, 2012/05/02 23:15:08]

nit: Can this be a member of the MetricsService instead?  ChromeBrowserMain is
already ginormous -- it would be nice not to add to the problem :)

[SteveT, 2012/05/03 04:02:52]

I'm not super familiar with BrowserProcess vs BrowserMainParts, so this question
can help us figure out if this should go here: Why did you choose to have the
VariationService live here and not in the BrowserProcess, where MetricsService
live? Is it because we want a lifespan similar to FieldTrialList?

[jwd, 2012/05/03 22:27:49]

I put it here because I was modeling it after the TranslateManager. I will look
into putting it in MetricsService instead or somewhere else.
On 2012/05/03 04:02:52, SteveT wrote:

+
   // Tests can set this to true to disable restricting cookie access in the
   // network stack, as this can only be done once.
   static bool disable_enforcing_cookie_policies_for_tests_;
 
   friend class BrowserMainTest;
+
   FRIEND_TEST_ALL_PREFIXES(BrowserMainTest,
                            WarmConnectionFieldTrial_WarmestSocket);
   FRIEND_TEST_ALL_PREFIXES(BrowserMainTest, WarmConnectionFieldTrial_Random);
   FRIEND_TEST_ALL_PREFIXES(BrowserMainTest, WarmConnectionFieldTrial_Invalid);
   DISALLOW_COPY_AND_ASSIGN(ChromeBrowserMainParts);
 };
 
 // Records the conditions that can prevent Breakpad from generating and
 // sending crash reports.  The presence of a Breakpad handler (after
 // attempting to initialize crash reporting) and the presence of a debugger
 // are registered with the UMA metrics service.
 void RecordBreakpadStatusUMA(MetricsService* metrics);
 
 // Displays a warning message if some minimum level of OS support is not
 // present on the current platform.
 void WarnAboutMinimumSystemRequirements();
 
 // Records the time from our process' startup to the present time in
 // the UMA histogram |metric_name|.
 void RecordBrowserStartupTime();
 
 // Records a time value to an UMA histogram in the context of the
 // PreReadExperiment field-trial. This also reports to the appropriate
 // sub-histogram (_PreRead(Enabled|Disabled)).
 void RecordPreReadExperimentTime(const char* name, base::TimeDelta time);
 
 #endif  // CHROME_BROWSER_CHROME_BROWSER_MAIN_H_