Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2585)

Unified Diff: chrome/browser/signin/signin_tracker_unittest.cc

Issue 10335015: Treat SyncCredentialsLost as an auth error (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: git try Created 8 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/signin/signin_tracker.cc ('k') | chrome/browser/sync/profile_sync_service.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/signin/signin_tracker_unittest.cc
diff --git a/chrome/browser/signin/signin_tracker_unittest.cc b/chrome/browser/signin/signin_tracker_unittest.cc
index ec2d14cec2fb173604da26ab54903f4ffc09c337..1d8f3991d09d5dc89ab5ba00d990fdaa9d3f34fb 100644
--- a/chrome/browser/signin/signin_tracker_unittest.cc
+++ b/chrome/browser/signin/signin_tracker_unittest.cc
@@ -93,7 +93,7 @@ TEST_F(SigninTrackerTest, GaiaSignInSucceeded) {
// SIGNIN_SUCCEEDED notification should lead us to get a GaiCredentialsValid()
// callback.
EXPECT_CALL(observer_, GaiaCredentialsValid());
- EXPECT_CALL(*mock_pss_, AreCredentialsAvailable())
+ EXPECT_CALL(*mock_pss_, IsSyncEnabledAndLoggedIn())
.WillRepeatedly(Return(false));
EXPECT_CALL(*mock_token_service_, HasTokenForService(_))
.WillRepeatedly(Return(false));
@@ -111,7 +111,9 @@ static void ExpectSignedInSyncService(ProfileSyncServiceMock* sync_service,
EXPECT_CALL(*token_service, HasTokenForService(_))
.WillRepeatedly(Return(true));
}
- EXPECT_CALL(*sync_service, AreCredentialsAvailable()).WillRepeatedly(
+ EXPECT_CALL(*sync_service, IsSyncEnabledAndLoggedIn()).WillRepeatedly(
+ Return(true));
+ EXPECT_CALL(*sync_service, IsSyncTokenAvailable()).WillRepeatedly(
Return(true));
EXPECT_CALL(*sync_service, waiting_for_auth()).WillRepeatedly(Return(false));
EXPECT_CALL(*sync_service, GetAuthError()).WillRepeatedly(ReturnRef(error));
@@ -217,7 +219,9 @@ TEST_F(SigninTrackerTest, NoGaiaSigninWhenServicesNotRunning) {
EXPECT_CALL(observer_, GaiaCredentialsValid());
EXPECT_CALL(*mock_token_service_, HasTokenForService(_))
.WillRepeatedly(Return(true));
- EXPECT_CALL(*mock_pss_, AreCredentialsAvailable()).WillRepeatedly(
+ EXPECT_CALL(*mock_pss_, IsSyncEnabledAndLoggedIn()).WillRepeatedly(
+ Return(false));
+ EXPECT_CALL(*mock_pss_, IsSyncTokenAvailable()).WillRepeatedly(
Return(false));
GoogleServiceSigninSuccessDetails details("username@gmail.com", "password");
content::NotificationService::current()->Notify(
@@ -230,7 +234,7 @@ TEST_F(SigninTrackerTest, GaiaSigninAfterSyncStarts) {
// Make sure that we don't get a SigninSuccess() callback until after the
// sync service reports that it's signed in.
EXPECT_CALL(observer_, GaiaCredentialsValid());
- EXPECT_CALL(*mock_pss_, AreCredentialsAvailable()).WillOnce(
+ EXPECT_CALL(*mock_pss_, IsSyncEnabledAndLoggedIn()).WillOnce(
Return(false));
EXPECT_CALL(*mock_token_service_, HasTokenForService(_))
.WillRepeatedly(Return(true));
@@ -251,7 +255,9 @@ TEST_F(SigninTrackerTest, SyncSigninError) {
// Make sure that we get a SigninFailed() callback if sync gets an error after
// initializaiton.
EXPECT_CALL(observer_, GaiaCredentialsValid());
- EXPECT_CALL(*mock_pss_, AreCredentialsAvailable()).WillRepeatedly(
+ EXPECT_CALL(*mock_pss_, IsSyncEnabledAndLoggedIn()).WillRepeatedly(
+ Return(false));
+ EXPECT_CALL(*mock_pss_, IsSyncTokenAvailable()).WillRepeatedly(
Return(false));
EXPECT_CALL(*mock_token_service_, HasTokenForService(_))
.WillRepeatedly(Return(true));
« no previous file with comments | « chrome/browser/signin/signin_tracker.cc ('k') | chrome/browser/sync/profile_sync_service.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698