Issue 10332311: Remove remaining uses of v8Locale. Fix the call to v8Intl.DateTimeFormat().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10332311: Remove remaining uses of v8Locale. Fix the call to v8Intl.DateTimeFormat(). (Closed)

Created:
8 years, 7 months ago by Oleg Eterevsky

Modified:
8 years, 7 months ago

Reviewers:
Nebojša Ćirić, dgozman

CC:
chromium-reviews, rginda+watch_chromium.org, arv (Not doing code reviews)

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Remove remaining uses of v8Locale. Fix the call to v8Intl.DateTimeFormat(). Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=138493

Patch Set 1 #

Total comments: 2

Created: 8 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+18 lines, -7 lines)			Patch
	M	chrome/browser/resources/file_manager/js/file_manager.js	View		2 chunks	+3 lines, -7 lines	0 comments	Download
	M	chrome/browser/resources/file_manager/js/mock_chrome.js	View		1 chunk	+15 lines, -0 lines	2 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Nebojša Ćirić

lgtm http://codereview.chromium.org/10332311/diff/1/chrome/browser/resources/file_manager/js/mock_chrome.js File chrome/browser/resources/file_manager/js/mock_chrome.js (right): http://codereview.chromium.org/10332311/diff/1/chrome/browser/resources/file_manager/js/mock_chrome.js#newcode732 chrome/browser/resources/file_manager/js/mock_chrome.js:732: */ Just a question - do you still ...

8 years, 7 months ago (2012-05-23 15:57:37 UTC) #3

Oleg Eterevsky

8 years, 7 months ago (2012-05-23 16:19:23 UTC) #4

http://codereview.chromium.org/10332311/diff/1/chrome/browser/resources/file_...
File chrome/browser/resources/file_manager/js/mock_chrome.js (right):

http://codereview.chromium.org/10332311/diff/1/chrome/browser/resources/file_...
chrome/browser/resources/file_manager/js/mock_chrome.js:732: */
On 2012/05/23 15:57:38, Nebojša Ćirić wrote:
> Just a question - do you still need this section? I am maybe missing the
goal...

We are using these mocks to run file browser in a usual Chrome -- it allows to
debug much of the code without compiling anything. So till our desktop browsers
are upgraded to M20, it's useful to have these mocks.

Expand Messages | Collapse Messages