Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1262)

Unified Diff: chrome/browser/resources/file_manager/js/file_manager.js

Issue 10332311: Remove remaining uses of v8Locale. Fix the call to v8Intl.DateTimeFormat(). (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 8 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/file_manager/js/file_manager.js
===================================================================
--- chrome/browser/resources/file_manager/js/file_manager.js (revision 138460)
+++ chrome/browser/resources/file_manager/js/file_manager.js (working copy)
@@ -46,9 +46,6 @@
FileManager.DialogType.SELECT_OPEN_MULTI_FILE,
FileManager.DialogType.FULL_PAGE]);
- // TODO(dgozman): This will be changed to LocaleInfo.
- this.locale_ = new v8Locale(navigator.language);
-
this.initFileSystem_();
this.volumeManager_ = VolumeManager.getInstance();
this.initDom_();
@@ -438,15 +435,14 @@
this.metadataCache_ = MetadataCache.createFull();
this.dateFormatter_ = v8Intl.DateTimeFormat(
- {} /* default locale */,
+ [] /* default locale */,
{year: 'numeric', month: 'short', day: 'numeric',
hour: 'numeric', minute: 'numeric'});
this.timeFormatter_ = v8Intl.DateTimeFormat(
- {} /* default locale */,
+ [] /* default locale */,
{hour: 'numeric', minute: 'numeric'});
- this.collator_ = this.locale_.createCollator({
- 'numeric': true, 'ignoreCase': true, 'ignoreAccents': true});
+ this.collator_ = v8Intl.Collator([], {numeric: true, sensitivity: 'base'});
// Optional list of file types.
this.fileTypes_ = this.params_.typeList;

Powered by Google App Engine
This is Rietveld 408576698