Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(144)

Issue 10332275: Fix crash in UMA reporting of accelerated compositing in WebGL codepaths. (Closed)

Created:
8 years, 7 months ago by Ami GONE FROM CHROMIUM
Modified:
8 years, 7 months ago
CC:
chromium-reviews, feature-media-reviews_chromium.org, darin-cc_chromium.org
Visibility:
Public.

Description

Fix crash in UMA reporting of accelerated compositing in WebGL codepaths. BUG=129030 TEST=fast/canvas/webgl/ layouttests all pass Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=138160

Patch Set 1 #

Total comments: 2

Patch Set 2 : nit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -3 lines) Patch
M webkit/media/webmediaplayer_impl.cc View 1 2 chunks +7 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
scherkus (not reviewing)
lgtm -- feel free to fix up as discussed offline if you feel it's necessary ...
8 years, 7 months ago (2012-05-21 19:56:28 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/fischman@chromium.org/10332275/1
8 years, 7 months ago (2012-05-21 19:58:13 UTC) #2
Peter Kasting
https://chromiumcodereview.appspot.com/10332275/diff/1/webkit/media/webmediaplayer_impl.cc File webkit/media/webmediaplayer_impl.cc (right): https://chromiumcodereview.appspot.com/10332275/diff/1/webkit/media/webmediaplayer_impl.cc#newcode576 webkit/media/webmediaplayer_impl.cc:576: DCHECK_EQ(frame_->view()->isAcceleratedCompositingActive(), true); Should this spot be changed too? Also, ...
8 years, 7 months ago (2012-05-21 19:59:32 UTC) #3
Ami GONE FROM CHROMIUM
https://chromiumcodereview.appspot.com/10332275/diff/1/webkit/media/webmediaplayer_impl.cc File webkit/media/webmediaplayer_impl.cc (right): https://chromiumcodereview.appspot.com/10332275/diff/1/webkit/media/webmediaplayer_impl.cc#newcode576 webkit/media/webmediaplayer_impl.cc:576: DCHECK_EQ(frame_->view()->isAcceleratedCompositingActive(), true); On 2012/05/21 19:59:33, Peter Kasting wrote: > ...
8 years, 7 months ago (2012-05-21 20:01:34 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/fischman@chromium.org/10332275/2002
8 years, 7 months ago (2012-05-21 20:01:50 UTC) #5
commit-bot: I haz the power
8 years, 7 months ago (2012-05-21 22:52:00 UTC) #6
Try job failure for 10332275-2002 (retry) on win_rel for step "sync_unit_tests".
It's a second try, previously, steps "base_unittests, sync_unit_tests" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

Powered by Google App Engine
This is Rietveld 408576698