Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(67)

Issue 10332259: Add some missing <ex> nodes to placeholders. (Closed)

Created:
8 years, 7 months ago by tony
Modified:
8 years, 7 months ago
Reviewers:
Jói
CC:
chromium-reviews
Visibility:
Public.

Description

Add some missing <ex> nodes to placeholders. Fixes some lint errors from the translation console. BUG=None TEST=None Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=138358

Patch Set 1 #

Patch Set 2 : html examples #

Unified diffs Side-by-side diffs Delta from patch set Stats (+59 lines, -59 lines) Patch
M chrome/app/generated_resources.grd View 29 chunks +59 lines, -59 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
tony
Some <ph> nodes are still missing examples because they are just markup. E.g., what should ...
8 years, 7 months ago (2012-05-18 20:57:11 UTC) #1
Jói
LGTM I would just use the actual HTML code for the <ex>. This is what ...
8 years, 7 months ago (2012-05-21 10:39:32 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tony@chromium.org/10332259/2001
8 years, 7 months ago (2012-05-21 17:45:55 UTC) #3
commit-bot: I haz the power
Try job failure for 10332259-2001 (retry) (retry) on win_rel for step "compile" (clobber build). It's ...
8 years, 7 months ago (2012-05-21 23:28:45 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tony@chromium.org/10332259/2001
8 years, 7 months ago (2012-05-21 23:31:25 UTC) #5
commit-bot: I haz the power
Try job failure for 10332259-2001 (retry) (retry) on win_rel for steps "base_unittests, sync_unit_tests". It's a ...
8 years, 7 months ago (2012-05-22 04:50:04 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tony@chromium.org/10332259/2001
8 years, 7 months ago (2012-05-22 16:31:06 UTC) #7
commit-bot: I haz the power
8 years, 7 months ago (2012-05-22 18:47:34 UTC) #8
Try job failure for 10332259-2001 (retry) on win for step "compile" (clobber
build).
It's a second try, previously, step "compile" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win&number...

Powered by Google App Engine
This is Rietveld 408576698