|
|
Created:
8 years, 7 months ago by tony Modified:
8 years, 7 months ago Reviewers:
Jói CC:
chromium-reviews Base URL:
svn://svn.chromium.org/chrome/trunk/src Visibility:
Public. |
DescriptionAdd some missing <ex> nodes to placeholders.
Fixes some lint errors from the translation console.
BUG=None
TEST=None
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=138358
Patch Set 1 #Patch Set 2 : html examples #
Messages
Total messages: 8 (0 generated)
Some <ph> nodes are still missing examples because they are just markup. E.g., what should be in <ex> for a <strong> tag?
LGTM I would just use the actual HTML code for the <ex>. This is what e.g. grit.gather.tr_html does when automatically creating placeholders for inline HTML elements (e.g. <b> and <i>) and it doesn't seem to have confused translators so far. Cheers, Jói On Fri, May 18, 2012 at 8:57 PM, <tony@chromium.org> wrote: > Reviewers: Jói, > > Message: > Some <ph> nodes are still missing examples because they are just markup. > E.g., > what should be in <ex> for a <strong> tag? > > Description: > Add some missing <ex> nodes to placeholders. > > Fixes some lint errors from the translation console. > > BUG=None > TEST=None > > > Please review this at https://chromiumcodereview.appspot.com/10332259/ > > SVN Base: svn://svn.chromium.org/chrome/trunk/src > > Affected files: > M chrome/app/generated_resources.grd > > > Index: chrome/app/generated_resources.grd > diff --git a/chrome/app/generated_resources.grd > b/chrome/app/generated_resources.grd > index > 6ef90e8e72bbe8bc02a8fb068a04c52a9bd0b9f0..b2d66bc5c0210cb3a1b406f9419f8d2f9795b8e2 > 100644 > --- a/chrome/app/generated_resources.grd > +++ b/chrome/app/generated_resources.grd > @@ -5442,13 +5442,13 @@ Keep your key file in a safe place. You will need it > to create new versions of y > Enable various alerts about changes in extension state. > </message> > <message name="IDS_FLAGS_ENABLE_MEDIA_SOURCE_NAME" desc="Title for the > flag to enable the Media Source API on <video> elements."> > - Enable Media Source API on <ph name="VIDEO_HTML"><video></ph> > elements. > + Enable Media Source API on <ph > name="VIDEO_HTML"><video><ex><video></ex></ph> elements. > </message> > <message name="IDS_FLAGS_ENABLE_MEDIA_SOURCE_DESCRIPTION" > desc="Description for the flag to enable the Media Source API on > <video> elements."> > Enable experimental Media Source API on the video elements. This API > allows JavaScript to send media data directly to a video element. > </message> > <message name="IDS_FLAGS_ENABLE_ENCRYPTED_MEDIA_NAME" desc="Title for > the flag to enable the Encrypted Media Extensions on <video> > elements."> > - Enable Encrypted Media Extensions on <ph > name="VIDEO_HTML"><video></ph> elements. > + Enable Encrypted Media Extensions on <ph > name="VIDEO_HTML"><video><ex><video></ex></ph> elements. > </message> > <message name="IDS_FLAGS_ENABLE_ENCRYPTED_MEDIA_DESCRIPTION" > desc="Description for the flag to enable the Encrypted Media Extensions on > <video> elements."> > Enable experimental Encrypted Media Extensions on the video > elements. > @@ -7769,13 +7769,13 @@ The following plug-in is unresponsive: <ph > name="PLUGIN_NAME">$1 > but can also be the result of a misconfigured firewall or proxy > server. > </message> > <message name="IDS_ERRORPAGES_SUMMARY_FILE_ACCESS_DENIED" > desc="Summary in the error page when we can't open a file."> > - The file at <ph name="URL"><strong > jscontent="failedUrl"></strong></ph> is not readable. It may have > been removed, moved, or file permissions may be preventing access. > + The file at <ph name="URL"><strong > jscontent="failedUrl"></strong><ex>http://www.google.com/</ex></ph> > is not readable. It may have been removed, moved, or file permissions may > be preventing access. > </message> > <if expr="pp_ifdef('android')"> > <message name="IDS_ERRORPAGES_SUMMARY_NETWORK_ACCESS_DENIED" > desc="Mobile: Summary in the error page when we're not being allowed to > access the network."> > <ph name="PRODUCT_NAME"><span > jscontent="productName"></span><ex>Google Chrome</ex></ph> > is having trouble accessing the network. > - <ph name="LINE_BREAK"><br /><br /></ph> > + <ph name="LINE_BREAK"><br /><br /><ex>\n\n</ex></ph> > This may be because your firewall or antivirus software wrongly > thinks > <ph name="PRODUCT_NAME"><span > jscontent="productName"></span><ex>Google Chrome</ex></ph> > is an intruder on your mobile device and is blocking it from > connecting to the Internet. > @@ -8166,12 +8166,12 @@ The following plug-in is unresponsive: <ph > name="PLUGIN_NAME">$1 > > <message name="IDS_ERRORPAGES_SUMMARY_TEMPORARILY_THROTTLED" > desc="Summary in the error page when we temporarily stop sending requests to > a server in order to avoid DDoS."> > It is likely that the server hosting the webpage has been overloaded > or encountered an error. > - In order to avoid letting extensions cause too much traffic and > making the situation worse, > + In order to avoid letting extensions cause too much traffic and > making the situation worse, > <ph name="PRODUCT_NAME"><span > jscontent="productName"></span><ex>Google Chrome</ex></ph> > - has temporarily stopped allowing requests by extensions to this URL. > - <ph name="LINE_BREAK"><br /><br /></ph> > + has temporarily stopped allowing requests by extensions to this > URL. > + <ph name="LINE_BREAK"><br /><br /><ex>\n\n</ex></ph> > If you think this behavior is undesirable, for example, you are > debugging your own website, please > - visit <ph > name="URL_FOR_MORE_INFO"><strong>http://dev.chromium.org/throttling</strong></ph>, > + visit <ph > name="URL_FOR_MORE_INFO"><strong>http://dev.chromium.org/throttling</strong><ex>http://dev.chromium.org/throttling</ex></ph>, > where you can find more information including how to disable the > feature. > </message> > <message name="IDS_ERRORPAGES_DETAILS_TEMPORARILY_THROTTLED" desc="The > error message displayed when we temporarily stop sending requests to a > server in order to avoid DDoS."> > @@ -10647,7 +10647,7 @@ Some features may be unavailable. Please check that > the profile exists and you > Overwrite original > </message> > <message name="IDS_FILE_BROWSER_GALLERY_OVERWRITE_BUBBLE" desc="In the > Gallery, text in the bubble informing user about saving and overwriting > original file."> > - Your edits are saved automatically.<ph > name="BREAKS"><br><br></ph>To keep a copy of the original image, > uncheck "Overwrite original" > + Your edits are saved automatically.<ph > name="BREAKS"><br><br><ex>\n\n</ex></ph>To keep a copy of the > original image, uncheck "Overwrite original" > </message> > <message name="IDS_FILE_BROWSER_GALLERY_UNSAVED_CHANGES" desc="In the > Gallery, message informing about unsaved changes, when user tries to close > the tab."> > Changes are not saved yet. > @@ -10838,9 +10838,9 @@ Some features may be unavailable. Please check that > the profile exists and you > Retry > </message> > <message name="IDS_FILE_BROWSER_GDATA_OUT_OF_SPACE_MESSAGE" > desc="Message informing the user how to make more space available to save > the selected file offline."> > - To save "<ph name="FILE_NAME">$1<ex>document.pdf</ex></ph>" offline > you must free up an additional <ph name="TOTAL_FILE_SIZE">$2<ex>3.3 > MB</ex></ph> of space:<ph name="MARKUP_1"><br></ph> > - <ph name="MARKUP_2"><ul><li></ph>unpin files that you > no longer need to access offline<ph name="MARKUP_3"></li></ph> > - <ph name="MARKUP_4"><li></ph>delete files from your Downloads > folder<ph name="MARKUP_5"></li></ul></ph> > + To save "<ph name="FILE_NAME">$1<ex>document.pdf</ex></ph>" offline > you must free up an additional <ph name="TOTAL_FILE_SIZE">$2<ex>3.3 > MB</ex></ph> of space:<ph name="MARKUP_1"><br><ex>\n</ex></ph> > + <ph name="MARKUP_2"><ul><li><ex>* </ex></ph>unpin files > that you no longer need to access offline<ph > name="MARKUP_3"></li></ph> > + <ph name="MARKUP_4"><li><ex>* </ex></ph>delete files from > your Downloads folder<ph name="MARKUP_5"></li></ul></ph> > </message> > <message name="IDS_FILE_BROWSER_GDATA_SERVER_OUT_OF_SPACE_MESSAGE" > desc="Message informing the user how to make more space available on Google > Drive server side."> > You do not have enough space in <ph name="PRODUCT_NAME">$1<ex>Google > Drive</ex></ph> to save "<ph name="FILE_NAME">$2<ex>document.pdf</ex></ph>". > Please remove files or <ph name="BEGIN_LINK"><a target='_blank' > href='$3'></ph>buy more storage space<ph name="END_LINK"></a></ph>. > @@ -10852,11 +10852,11 @@ Some features may be unavailable. Please check > that the profile exists and you > All files saved in this folder are backed up online automatically > </message> > <message name="IDS_FILE_BROWSER_GDATA_WELCOME_TEXT_LONG" desc="In the > Welcome to Google Drive banner, text of the welcome message, long version."> > - <ph name="MARKUP_1"><p><strong></ph>Access files from > everywhere, even offline.<ph name="MARKUP_2"></strong></ph> > + <ph > name="MARKUP_1"><p><strong><ex><strong></ex></ph>Access > files from everywhere, even offline.<ph > name="MARKUP_2"></strong><ex></strong></ex></ph> > Files in <ph name="PRODUCT_NAME">$1<ex>Google Drive</ex></ph> are > up-to-date and available from any device.<ph name="MARKUP_3"></p></ph> > - <ph name="MARKUP_4"><p><strong></ph>Keep your files > safe.<ph name="MARKUP_5"></strong></ph> > + <ph > name="MARKUP_4"><p><strong><ex><strong></ex></ph>Keep your > files safe.<ph name="MARKUP_5"></strong><ex></strong></ex></ph> > No matter what happens to your device, your files are safely stored > in <ph name="PRODUCT_NAME">$1<ex>Google Drive</ex></ph>.<ph > name="MARKUP_6"></p></ph> > - <ph name="MARKUP_7"><p><strong></ph>Share, create and > collaborate<ph name="MARKUP_8"></strong></ph> > + <ph > name="MARKUP_7"><p><strong><ex><strong></ex></ph>Share, > create and collaborate<ph > name="MARKUP_8"></strong><ex></strong></ex></ph> > on files with others all in one place.<ph > name="MARKUP_9"></p></ph> > </message> > <message name="IDS_FILE_BROWSER_GDATA_WELCOME_DISMISS" desc="In the > Welcome to Google Drive banner, a text on the button to dismiss the > banner."> > >
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tony@chromium.org/10332259/2001
Try job failure for 10332259-2001 (retry) (retry) on win_rel for step "compile" (clobber build). It's a second try, previously, step "compile" failed. http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tony@chromium.org/10332259/2001
Try job failure for 10332259-2001 (retry) (retry) on win_rel for steps "base_unittests, sync_unit_tests". It's a second try, previously, steps "base_unittests, sync_unit_tests" failed. http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tony@chromium.org/10332259/2001
Try job failure for 10332259-2001 (retry) on win for step "compile" (clobber build). It's a second try, previously, step "compile" failed. http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win&number... |