Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(52)

Issue 10332251: Strip CRs from DEPS file that have them. (Closed)

Created:
8 years, 7 months ago by Ami GONE FROM CHROMIUM
Modified:
8 years, 7 months ago
CC:
chromium-reviews, jochen+watch-content_chromium.org, grt+watch_chromium.org, jam, apatrick_chromium, joi+watch-content_chromium.org, darin-cc_chromium.org
Visibility:
Public.

Description

Strip CRs from DEPS file that have them. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=137881

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -15 lines) Patch
M chrome/installer/setup/DEPS View 1 chunk +4 lines, -4 lines 0 comments Download
M content/common/gpu/DEPS View 1 chunk +11 lines, -11 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Ami GONE FROM CHROMIUM
8 years, 7 months ago (2012-05-18 16:30:20 UTC) #1
Ken Russell (switch to Gerrit)
lgtm
8 years, 7 months ago (2012-05-18 16:48:43 UTC) #2
grt (UTC plus 2)
lgtm
8 years, 7 months ago (2012-05-18 16:52:19 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/fischman@chromium.org/10332251/1
8 years, 7 months ago (2012-05-18 16:53:08 UTC) #4
commit-bot: I haz the power
8 years, 7 months ago (2012-05-18 16:53:10 UTC) #5
Failed to apply patch for chrome/installer/setup/DEPS:
While running patch -p1 --forward --force;
patching file chrome/installer/setup/DEPS
Hunk #1 FAILED at 1.
1 out of 1 hunk FAILED -- saving rejects to file chrome/installer/setup/DEPS.rej

Powered by Google App Engine
This is Rietveld 408576698