chrome/browser/extensions/page_action_controller.cc - Issue 10332235: Make the page action space show extensions with active content scripts or

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/page_action_controller.cc

Issue 10332235: Make the page action space show extensions with active content scripts or (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: . Created 8 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/extension_tab_helper.cc ('k') | chrome/browser/extensions/script_badge_controller.h » ('j') | chrome/browser/extensions/script_badge_controller.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/page_action_controller.cc

diff --git a/chrome/browser/extensions/page_action_controller.cc b/chrome/browser/extensions/page_action_controller.cc

index ed3c8e67d540433c0a7839cbdc61be834f255d65..268c4bfb429b56fee15c080c485b7bb21cb05123 100644

--- a/chrome/browser/extensions/page_action_controller.cc

+++ b/chrome/browser/extensions/page_action_controller.cc

@@ -53,8 +53,8 @@ ActionBoxController::Action PageActionController::OnClicked(

int tab_id = ExtensionTabUtil::GetTabId(tab_contents_->web_contents());

switch (mouse_button) {

- case 1:

- case 2:

+ case 1: // left

+ case 2: // middle

Matt Perry 2012/05/18 19:31:31 2 spaces before comments

not at google - send to devlin 2012/05/18 22:51:27 Done.

if (page_action->HasPopup(tab_id))

return ACTION_SHOW_POPUP;

@@ -67,7 +67,7 @@ ActionBoxController::Action PageActionController::OnClicked(

mouse_button);

return ACTION_NONE;

- case 3:

+ case 3: // right

return extension->ShowConfigureContextMenus() ?

ACTION_SHOW_CONTEXT_MENU : ACTION_NONE;

}