Make the page action space show extensions with active content scripts or

chrome/browser/extensions/page_action_controller.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/extensions/page_action_controller.h"
 
 #include "chrome/browser/ui/tab_contents/tab_contents_wrapper.h"
 #include "chrome/browser/extensions/extension_browser_event_router.h"
 #include "chrome/browser/extensions/extension_service.h"
 #include "chrome/browser/extensions/extension_system.h"
@@ skipping 35 matching lines @@
 ActionBoxController::Action PageActionController::OnClicked(
     const std::string& extension_id, int mouse_button) {
   const Extension* extension =
       GetExtensionService()->extensions()->GetByID(extension_id);
   CHECK(extension);
   ExtensionAction* page_action = extension->page_action();
   CHECK(page_action);
   int tab_id = ExtensionTabUtil::GetTabId(tab_contents_->web_contents());
 
   switch (mouse_button) {
-    case 1:
-    case 2:
+    case 1: // left
+    case 2: // middle

[Matt Perry, 2012/05/18 19:31:31]

2 spaces before comments

[not at google - send to devlin, 2012/05/18 22:51:27]

Done.

       if (page_action->HasPopup(tab_id))
         return ACTION_SHOW_POPUP;
 
       GetExtensionService()->browser_event_router()->PageActionExecuted(
           tab_contents_->profile(),
           extension->id(),
           page_action->id(),
           tab_id,
           tab_contents_->web_contents()->GetURL().spec(),
           mouse_button);
       return ACTION_NONE;
 
-    case 3:
+    case 3: // right
       return extension->ShowConfigureContextMenus() ?
           ACTION_SHOW_CONTEXT_MENU : ACTION_NONE;
   }
 
   return ACTION_NONE;
 }
 
 void PageActionController::OnPageActionStateChanged() {
   content::NotificationService::current()->Notify(
       chrome::NOTIFICATION_EXTENSION_ACTION_BOX_UPDATED,
@@ skipping 11 matching lines @@
       chrome::NOTIFICATION_EXTENSION_PAGE_ACTION_VISIBILITY_CHANGED,
       content::Source<ExtensionAction>(&bogus_action),
       content::Details<content::WebContents>(tab_contents_->web_contents()));
 }
 
 ExtensionService* PageActionController::GetExtensionService() {
   return ExtensionSystem::Get(tab_contents_->profile())->extension_service();
 }
 
 }  // namespace extensions