Issue 10332117: Revert 136573 - Extract StartupTabs and startup types from StartupBrowserCreator.

Issue 10332117: Revert 136573 - Extract StartupTabs and startup types from StartupBrowserCreator. (Closed)

Created:
8 years, 7 months ago by Ben Goodger (Google)

Modified:
8 years, 7 months ago

Reviewers:
Ben Goodger (Google)

CC:
chromium-reviews, rginda+watch_chromium.org, stevenjb+watch_chromium.org, nkostylev+watch_chromium.org, davemoore+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Revert 136573 - Extract StartupTabs and startup types from StartupBrowserCreator. BUG=none TEST=none TBR=sky Review URL: https://chromiumcodereview.appspot.com/10384106 TBR=ben@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=136582

Patch Set 1 #

Created: 8 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+1103 lines, -1207 lines)			Patch
M	chrome/browser/app_controller_mac.mm	View	3 chunks	+6 lines, -6 lines	0 comments	Download
M	chrome/browser/chromeos/login/login_utils.cc	View	1 chunk	+6 lines, -5 lines	0 comments	Download
M	chrome/browser/profiles/avatar_menu_model.cc	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/profiles/profile_manager.h	View	2 chunks	+3 lines, -3 lines	0 comments	Download
M	chrome/browser/profiles/profile_manager.cc	View	3 chunks	+4 lines, -5 lines	0 comments	Download
M	chrome/browser/protector/base_setting_change.h	View	2 chunks	+3 lines, -3 lines	0 comments	Download
M	chrome/browser/protector/composite_settings_change.h	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/browser/protector/homepage_change.cc	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/browser/protector/session_startup_change.cc	View	5 chunks	+12 lines, -12 lines	0 comments	Download
M	chrome/browser/protector/session_startup_change_unittest.cc	View	3 chunks	+3 lines, -4 lines	0 comments	Download
M	chrome/browser/tabs/pinned_tab_codec.h	View	3 chunks	+6 lines, -4 lines	0 comments	Download
M	chrome/browser/tabs/pinned_tab_codec.cc	View	6 chunks	+11 lines, -10 lines	0 comments	Download
M	chrome/browser/tabs/pinned_tab_codec_unittest.cc	View	2 chunks	+1 line, -2 lines	0 comments	Download
M	chrome/browser/tabs/pinned_tab_test_utils.h	View	1 chunk	+3 lines, -2 lines	0 comments	Download
M	chrome/browser/tabs/pinned_tab_test_utils.cc	View	2 chunks	+4 lines, -2 lines	0 comments	Download
M	chrome/browser/ui/browser_browsertest.cc	View	3 chunks	+9 lines, -8 lines	0 comments	Download
M	chrome/browser/ui/startup/startup_browser_creator.h	View	4 chunks	+146 lines, -5 lines	0 comments	Download
M	chrome/browser/ui/startup/startup_browser_creator.cc	View	12 chunks	+850 lines, -26 lines	0 comments	Download
M	chrome/browser/ui/startup/startup_browser_creator_browsertest.cc	View	9 chunks	+34 lines, -26 lines	0 comments	Download
D	chrome/browser/ui/startup/startup_browser_creator_impl.h	View	1 chunk	+0 lines, -141 lines	0 comments	Download
D	chrome/browser/ui/startup/startup_browser_creator_impl.cc	View	1 chunk	+0 lines, -856 lines	0 comments	Download
D	chrome/browser/ui/startup/startup_tab.h	View	1 chunk	+0 lines, -35 lines	0 comments	Download
D	chrome/browser/ui/startup/startup_tab.cc	View	1 chunk	+0 lines, -13 lines	0 comments	Download
D	chrome/browser/ui/startup/startup_types.h	View	1 chunk	+0 lines, -30 lines	0 comments	Download
M	chrome/chrome_browser.gypi	View	1 chunk	+0 lines, -5 lines	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages