Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(837)

Issue 10384106: Extract StartupTabs and startup types from StartupBrowserCreator. (Closed)

Created:
8 years, 7 months ago by Ben Goodger (Google)
Modified:
8 years, 7 months ago
Reviewers:
sky
CC:
chromium-reviews, rginda+watch_chromium.org, stevenjb+watch_chromium.org, nkostylev+watch_chromium.org, davemoore+watch_chromium.org
Visibility:
Public.

Description

Extract StartupTabs and startup types from StartupBrowserCreator. BUG=none TEST=none TBR=sky Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=136573 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=136658

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+127 lines, -1098 lines) Patch
M chrome/browser/app_controller_mac.mm View 1 2 3 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/chromeos/login/login_utils.cc View 1 2 1 chunk +5 lines, -6 lines 0 comments Download
M chrome/browser/profiles/avatar_menu_model.cc View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/profiles/profile_manager.h View 1 2 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/profiles/profile_manager.cc View 1 2 3 chunks +5 lines, -4 lines 0 comments Download
M chrome/browser/protector/base_setting_change.h View 1 2 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/protector/composite_settings_change.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/protector/homepage_change.cc View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/protector/session_startup_change.cc View 1 2 5 chunks +12 lines, -12 lines 0 comments Download
M chrome/browser/protector/session_startup_change_unittest.cc View 1 2 3 chunks +4 lines, -3 lines 0 comments Download
M chrome/browser/tabs/pinned_tab_codec.h View 1 2 3 chunks +4 lines, -6 lines 0 comments Download
M chrome/browser/tabs/pinned_tab_codec.cc View 1 2 6 chunks +10 lines, -11 lines 0 comments Download
M chrome/browser/tabs/pinned_tab_codec_unittest.cc View 1 2 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/tabs/pinned_tab_test_utils.h View 1 2 1 chunk +2 lines, -3 lines 0 comments Download
M chrome/browser/tabs/pinned_tab_test_utils.cc View 1 2 2 chunks +2 lines, -4 lines 0 comments Download
M chrome/browser/ui/browser_browsertest.cc View 1 2 3 chunks +8 lines, -9 lines 0 comments Download
M chrome/browser/ui/startup/startup_browser_creator.h View 1 2 4 chunks +5 lines, -146 lines 0 comments Download
M chrome/browser/ui/startup/startup_browser_creator.cc View 1 2 12 chunks +26 lines, -850 lines 0 comments Download
M chrome/browser/ui/startup/startup_browser_creator_browsertest.cc View 1 2 9 chunks +26 lines, -34 lines 0 comments Download
A + chrome/browser/ui/startup/startup_browser_creator_impl.h View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/browser/ui/startup/startup_browser_creator_impl.cc View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/browser/ui/startup/startup_tab.h View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/browser/ui/startup/startup_tab.cc View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/browser/ui/startup/startup_types.h View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
M chrome/chrome_browser.gypi View 1 2 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
Ben Goodger (Google)
8 years, 7 months ago (2012-05-10 21:46:13 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698