Remove reporting statistics reporting from chrome://media-internals and fix event logging.

Remove statistics reporting from chrome://media-internals and fix event logging.

Our internals page is for reporting things that are, like, internal. The statistics I'm removing are available from audio/video elements themselves, removing the need for including them on the internals page. They are also really spammy.

During the removal I also fixed a bug where we weren't reporting the associated parameters with each event (i.e., the name of the state for a PIPELINE_STATE_CHANGED event).

BUG=none
TEST=none

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=136357

[scherkus (not reviewing), 2012-05-10 02:41:56]

fischman: media/
estade: chrome/browser/resources/

[scherkus (not reviewing), 2012-05-10 02:45:03]

https://chromiumcodereview.appspot.com/10332082/diff/1006/media/base/media_lo...
File media/base/media_log.cc (right):

https://chromiumcodereview.appspot.com/10332082/diff/1006/media/base/media_lo...
media/base/media_log.cc:11: #include "base/memory/scoped_ptr.h"
this .h should be removed

https://chromiumcodereview.appspot.com/10332082/diff/1006/media/base/media_lo...
media/base/media_log.cc:139: : id_(g_media_log_count.GetNext()) {
crap I need to fix indent here

[Ami GONE FROM CHROMIUM, 2012-05-10 17:16:49]

LGTM % nits

https://chromiumcodereview.appspot.com/10332082/diff/1006/media/base/media_lo...
File media/base/media_log.cc (right):

https://chromiumcodereview.appspot.com/10332082/diff/1006/media/base/media_lo...
media/base/media_log.cc:139: : id_(g_media_log_count.GetNext()) {
single line?

https://chromiumcodereview.appspot.com/10332082/diff/1006/media/base/media_lo...
media/base/media_log.cc:144: void MediaLog::AddEvent(scoped_ptr<MediaLogEvent>
event) {}
Should this be pure-virtual?

[scherkus (not reviewing), 2012-05-10 17:31:23]

https://chromiumcodereview.appspot.com/10332082/diff/1006/media/base/media_lo...
File media/base/media_log.cc (right):

https://chromiumcodereview.appspot.com/10332082/diff/1006/media/base/media_lo...
media/base/media_log.cc:139: : id_(g_media_log_count.GetNext()) {
On 2012/05/10 17:16:49, Ami Fischman wrote:
> single line?

Done.

https://chromiumcodereview.appspot.com/10332082/diff/1006/media/base/media_lo...
media/base/media_log.cc:144: void MediaLog::AddEvent(scoped_ptr<MediaLogEvent>
event) {}
On 2012/05/10 17:16:49, Ami Fischman wrote:
> Should this be pure-virtual?

We create non-overridden MediaLogs in a few spots (tests, applications). Why?
not sure!

I wonder if this should be pure-virt and we have a subclass like MediaLogLogger
that VLOG(1)s the information so said tests/applications can quickly get some
logging information (i.e., pipeline state changes)

[Evan Stade, 2012-05-10 18:05:52]

js lgtm

[commit-bot: I haz the power, 2012-05-10 18:12:06]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/scherkus@chromium.org/10332082/10001

[commit-bot: I haz the power, 2012-05-10 18:49:36]

Try job failure for 10332082-10001 (retry) on mac_rel for step "compile"
(clobber build).
It's a second try, previously, step "compile" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&nu...