Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(902)

Unified Diff: media/base/media_log.h

Issue 10332082: Remove reporting statistics reporting from chrome://media-internals and fix event logging. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src
Patch Set: rebase Created 8 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/resources/media_internals/event_list.js ('k') | media/base/media_log.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/base/media_log.h
diff --git a/media/base/media_log.h b/media/base/media_log.h
index 9b87361ba1a9041b07e27ba33b213c231a7a6c99..fab1a63e013e46c295e915fddffa6e19513cc9da 100644
--- a/media/base/media_log.h
+++ b/media/base/media_log.h
@@ -7,7 +7,7 @@
#pragma once
#include "base/memory/ref_counted.h"
-#include "base/synchronization/lock.h"
+#include "base/memory/scoped_ptr.h"
#include "media/base/media_export.h"
#include "media/base/media_log_event.h"
#include "media/base/pipeline.h"
@@ -46,27 +46,14 @@ class MEDIA_EXPORT MediaLog : public base::RefCountedThreadSafe<MediaLog> {
scoped_ptr<MediaLogEvent> CreateBufferedExtentsChangedEvent(
size_t start, size_t current, size_t end);
- // Called when the pipeline statistics have been updated.
- // This gets called every frame, so we send the most recent stats after 500ms.
- // This function is NOT thread safe.
- void QueueStatisticsUpdatedEvent(PipelineStatistics stats);
-
protected:
friend class base::RefCountedThreadSafe<MediaLog>;
virtual ~MediaLog();
private:
- // Actually add a STATISTICS_UPDATED event.
- void AddStatisticsUpdatedEvent();
-
// A unique (to this process) id for this MediaLog.
int32 id_;
- // The most recent set of pipeline stats.
- PipelineStatistics last_statistics_;
- bool stats_update_pending_;
- base::Lock stats_lock_;
-
DISALLOW_COPY_AND_ASSIGN(MediaLog);
};
« no previous file with comments | « chrome/browser/resources/media_internals/event_list.js ('k') | media/base/media_log.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698