Inline type checks for complex uninstantiated types, e.g., List<T>.

runtime/vm/code_generator_x64.cc

Index: runtime/vm/code_generator_x64.cc
===================================================================
--- runtime/vm/code_generator_x64.cc	(revision 7346)
+++ runtime/vm/code_generator_x64.cc	(working copy)
@@ -1292,16 +1292,17 @@
   __ pushq(node_id_as_smi);
   __ pushq(RAX);  // Push the instance.
   __ PushObject(type);  // Push the type.
+  __ pushq(raw_null);  // No type arguments pushed (obsolete code).

[regis, 2012/05/04 21:53:39]

obsolete code? TODO?

[srdjan, 2012/05/04 23:01:58]

Code goes away with your submit.

   if (!type.IsInstantiated()) {
     GenerateInstantiatorTypeArguments(token_index);
   } else {
-    __ pushq(raw_null);  // Null instantiator.
+    __ pushq(raw_null);  // Null instantiator type arguments.
   }
   __ pushq(raw_null);  // SubtypeTestCache not yet supported.
   GenerateCallRuntime(node_id, token_index, kInstanceofRuntimeEntry);
   // Pop the two parameters supplied to the runtime entry. The result of the
   // instanceof runtime call will be left as the result of the operation.
-  __ addq(RSP, Immediate(6 * kWordSize));
+  __ addq(RSP, Immediate(7 * kWordSize));
   if (negate_result) {
     Label negate_done;
     __ popq(RDX);
@@ -1515,17 +1516,18 @@
   __ pushq(Immediate(Smi::RawValue(node_id)));  // node-id.
   __ pushq(RAX);  // Push the source object.
   __ PushObject(dst_type);  // Push the type of the destination.
+  __ pushq(raw_null);  // null instantiator (obsolete code).

[regis, 2012/05/04 21:53:39]

ditto

[srdjan, 2012/05/04 23:01:58]

Code is dead :-)!

   if (!dst_type.IsInstantiated()) {
     GenerateInstantiatorTypeArguments(token_index);
   } else {
-    __ pushq(raw_null);  // Null instantiator.
+    __ pushq(raw_null);  // Null instantiator type arguments.
   }
   __ PushObject(dst_name);  // Push the name of the destination.
   __ pushq(raw_null);  // SubtypeTestCache not yet supported.
   GenerateCallRuntime(node_id, token_index, kTypeCheckRuntimeEntry);
   // Pop the parameters supplied to the runtime entry. The result of the
   // type check runtime call is the checked value.
-  __ addq(RSP, Immediate(7 * kWordSize));
+  __ addq(RSP, Immediate(8 * kWordSize));
   __ popq(RAX);
 
   __ Bind(&done);