Inline type checks for complex uninstantiated types, e.g., List<T>.

runtime/vm/code_generator_x64.cc

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/globals.h"  // Needed here to get TARGET_ARCH_X64.
 #if defined(TARGET_ARCH_X64)
 
 #include "vm/code_generator.h"
 
 #include "lib/error.h"
@@ skipping 1274 matching lines @@
       }
     }
   }
   __ PushObject(Object::ZoneHandle());  // Make room for the result.
   const Immediate location = Immediate(Smi::RawValue(token_index));
   const Immediate node_id_as_smi = Immediate(Smi::RawValue(node_id));
   __ pushq(location);  // Push the source location.
   __ pushq(node_id_as_smi);
   __ pushq(RAX);  // Push the instance.
   __ PushObject(type);  // Push the type.
+  __ pushq(raw_null);  // No type arguments pushed (obsolete code).

[regis, 2012/05/04 21:53:39]

obsolete code? TODO?

[srdjan, 2012/05/04 23:01:58]

Code goes away with your submit.

   if (!type.IsInstantiated()) {
     GenerateInstantiatorTypeArguments(token_index);
   } else {
-    __ pushq(raw_null);  // Null instantiator.
+    __ pushq(raw_null);  // Null instantiator type arguments.
   }
   __ pushq(raw_null);  // SubtypeTestCache not yet supported.
   GenerateCallRuntime(node_id, token_index, kInstanceofRuntimeEntry);
   // Pop the two parameters supplied to the runtime entry. The result of the
   // instanceof runtime call will be left as the result of the operation.
-  __ addq(RSP, Immediate(6 * kWordSize));
+  __ addq(RSP, Immediate(7 * kWordSize));
   if (negate_result) {
     Label negate_done;
     __ popq(RDX);
     __ LoadObject(RAX, bool_true);
     __ cmpq(RDX, RAX);
     __ j(NOT_EQUAL, &negate_done, Assembler::kNearJump);
     __ LoadObject(RAX, bool_false);
     __ Bind(&negate_done);
     __ pushq(RAX);
   }
@@ skipping 193 matching lines @@
         }
       }
     }
   }
   __ Bind(&runtime_call);
   __ PushObject(Object::ZoneHandle());  // Make room for the result.
   __ pushq(Immediate(Smi::RawValue(token_index)));  // Source location.
   __ pushq(Immediate(Smi::RawValue(node_id)));  // node-id.
   __ pushq(RAX);  // Push the source object.
   __ PushObject(dst_type);  // Push the type of the destination.
+  __ pushq(raw_null);  // null instantiator (obsolete code).

[regis, 2012/05/04 21:53:39]

ditto

[srdjan, 2012/05/04 23:01:58]

Code is dead :-)!

   if (!dst_type.IsInstantiated()) {
     GenerateInstantiatorTypeArguments(token_index);
   } else {
-    __ pushq(raw_null);  // Null instantiator.
+    __ pushq(raw_null);  // Null instantiator type arguments.
   }
   __ PushObject(dst_name);  // Push the name of the destination.
   __ pushq(raw_null);  // SubtypeTestCache not yet supported.
   GenerateCallRuntime(node_id, token_index, kTypeCheckRuntimeEntry);
   // Pop the parameters supplied to the runtime entry. The result of the
   // type check runtime call is the checked value.
-  __ addq(RSP, Immediate(7 * kWordSize));
+  __ addq(RSP, Immediate(8 * kWordSize));
   __ popq(RAX);
 
   __ Bind(&done);
 }
 
 
 void CodeGenerator::GenerateArgumentTypeChecks() {
   const Function& function = parsed_function_.function();
   const SequenceNode& sequence_node = *parsed_function_.node_sequence();
   LocalScope* scope = sequence_node.scope();
@@ skipping 1123 matching lines @@
   const Error& error = Error::Handle(
       Parser::FormatError(script, token_index, "Error", format, args));
   va_end(args);
   Isolate::Current()->long_jump_base()->Jump(1, error);
   UNREACHABLE();
 }
 
 }  // namespace dart
 
 #endif  // defined TARGET_ARCH_X64