Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(556)

Issue 1031663002: Increase maximum file upload to 100MB, use cloudstorage python library (Closed)

Created:
5 years, 9 months ago by kustermann
Modified:
5 years, 9 months ago
Base URL:
https://github.com/dart-lang/pub-dartlang.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Increase maximum file upload to 100MB, use cloudstorage python library Using the deprecated files API from AppEngine can potentially result in errors like "FileNotOpenedError: ApplicationError: 10" -- this seems to be caused by a 30 second timeout. (See deprecation notice here: https://cloud.google.com/appengine/docs/python/googlestorage/functions) Using the replacement "cloudstorage" is either not suffering from this problem or is just faster (See: https://cloud.google.com/appengine/docs/python/googlecloudstorageclient/) R=rnystrom@google.com, sgjesse@google.com Committed: https://github.com/dart-lang/pub-dartlang/commit/854605603f17224dc40ac3d8f196be96053e3dd4

Patch Set 1 #

Patch Set 2 : #

Total comments: 2

Patch Set 3 : Add deprecation comment to old cloud_storage.py:open() function #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3151 lines, -4 lines) Patch
M app/app.yaml View 1 1 chunk +1 line, -1 line 0 comments Download
A app/cloudstorage View 1 chunk +1 line, -0 lines 0 comments Download
M app/handlers/cloud_storage.py View 1 2 4 chunks +15 lines, -2 lines 0 comments Download
M app/models/package.py View 1 chunk +1 line, -1 line 0 comments Download
A third_party/cloud_storage/MANIFEST.in View 1 chunk +1 line, -0 lines 0 comments Download
A third_party/cloud_storage/README View 1 chunk +5 lines, -0 lines 0 comments Download
A third_party/cloud_storage/cloudstorage/__init__.py View 1 chunk +29 lines, -0 lines 0 comments Download
A third_party/cloud_storage/cloudstorage/api_utils.py View 1 chunk +353 lines, -0 lines 0 comments Download
A third_party/cloud_storage/cloudstorage/cloudstorage_api.py View 1 chunk +451 lines, -0 lines 0 comments Download
A third_party/cloud_storage/cloudstorage/common.py View 1 chunk +429 lines, -0 lines 0 comments Download
A third_party/cloud_storage/cloudstorage/errors.py View 1 chunk +143 lines, -0 lines 0 comments Download
A third_party/cloud_storage/cloudstorage/rest_api.py View 1 chunk +258 lines, -0 lines 0 comments Download
A third_party/cloud_storage/cloudstorage/storage_api.py View 1 chunk +887 lines, -0 lines 0 comments Download
A third_party/cloud_storage/cloudstorage/test_utils.py View 1 chunk +25 lines, -0 lines 0 comments Download
A third_party/cloud_storage/distribute_setup.py View 1 chunk +524 lines, -0 lines 0 comments Download
A third_party/cloud_storage/setup.py View 1 chunk +28 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
kustermann
5 years, 9 months ago (2015-03-23 14:47:24 UTC) #2
Bob Nystrom
LGTM (though my memory of the pub server codebase is pretty weak these days, so ...
5 years, 9 months ago (2015-03-23 19:41:13 UTC) #3
Søren Gjesse
LGTM
5 years, 9 months ago (2015-03-24 12:16:40 UTC) #4
kustermann
Committed patchset #3 (id:60001) manually as 854605603f17224dc40ac3d8f196be96053e3dd4 (presubmit successful).
5 years, 9 months ago (2015-03-24 18:28:14 UTC) #6
kustermann
5 years, 9 months ago (2015-03-24 18:28:21 UTC) #7
Message was sent while issue was closed.
Thanks for the review.

https://chromiumcodereview.appspot.com/1031663002/diff/20001/app/handlers/clo...
File app/handlers/cloud_storage.py (right):

https://chromiumcodereview.appspot.com/1031663002/diff/20001/app/handlers/clo...
app/handlers/cloud_storage.py:218: def open(obj):
On 2015/03/23 19:41:13, Bob Nystrom wrote:
> Might be good to leave a comment that this is deprecated, or just remove it
> outright if it's not being used anymore.

Done.

It's still used -- I've added a deprecation comment.

Powered by Google App Engine
This is Rietveld 408576698