Hack to restrict runtime API to dev channel rather than experimental.

Hack to restrict runtime API to dev channel rather than experimental.

BUG=124167
TEST=no

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=137566

[Matt Perry, 2012-05-15 23:46:19]

yoz: please review
aa: FYI. Check out schema_generated_bindings.js for the hack

[Yoyo Zhou, 2012-05-16 00:04:06]

http://codereview.chromium.org/10310182/diff/1/chrome/browser/extensions/exte...
File chrome/browser/extensions/extension_service.cc (right):

http://codereview.chromium.org/10310182/diff/1/chrome/browser/extensions/exte...
chrome/browser/extensions/extension_service.cc:2446:
chrome::VersionInfo::GetChannel()));
Is there some reason we can't just call this in the constructor in
extension_dispatcher? After all, version_info is in chrome/common.

http://codereview.chromium.org/10310182/diff/1/chrome/renderer/extensions/ext...
File chrome/renderer/extensions/extension_dispatcher.h (right):

http://codereview.chromium.org/10310182/diff/1/chrome/renderer/extensions/ext...
chrome/renderer/extensions/extension_dispatcher.h:241: // The current channel.
From VersionInfo::GetChannel().
Do you want to put in a TODO(aa) to remove this later too?

[Matt Perry, 2012-05-16 00:19:53]

I also updated _permission_features.json and runtime.json with the necessary
bits to make the doc say "This API is under development"

http://codereview.chromium.org/10310182/diff/1/chrome/browser/extensions/exte...
File chrome/browser/extensions/extension_service.cc (right):

http://codereview.chromium.org/10310182/diff/1/chrome/browser/extensions/exte...
chrome/browser/extensions/extension_service.cc:2446:
chrome::VersionInfo::GetChannel()));
On 2012/05/16 00:04:06, Yoyo Zhou wrote:
> Is there some reason we can't just call this in the constructor in
> extension_dispatcher? After all, version_info is in chrome/common.

Yeah, you can't call it from the renderer because it touches the filesystem:
http://code.google.com/p/chromium/issues/detail?id=126535

http://codereview.chromium.org/10310182/diff/1/chrome/renderer/extensions/ext...
File chrome/renderer/extensions/extension_dispatcher.h (right):

http://codereview.chromium.org/10310182/diff/1/chrome/renderer/extensions/ext...
chrome/renderer/extensions/extension_dispatcher.h:241: // The current channel.
From VersionInfo::GetChannel().
On 2012/05/16 00:04:06, Yoyo Zhou wrote:
> Do you want to put in a TODO(aa) to remove this later too?

Done.

[Yoyo Zhou, 2012-05-16 00:23:40]

LGTM

http://codereview.chromium.org/10310182/diff/1/chrome/browser/extensions/exte...
File chrome/browser/extensions/extension_service.cc (right):

http://codereview.chromium.org/10310182/diff/1/chrome/browser/extensions/exte...
chrome/browser/extensions/extension_service.cc:2446:
chrome::VersionInfo::GetChannel()));
On 2012/05/16 00:19:54, Matt Perry wrote:
> On 2012/05/16 00:04:06, Yoyo Zhou wrote:
> > Is there some reason we can't just call this in the constructor in
> > extension_dispatcher? After all, version_info is in chrome/common.
> 
> Yeah, you can't call it from the renderer because it touches the filesystem:
> http://code.google.com/p/chromium/issues/detail?id=126535

Bummer.