Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5391)

Unified Diff: chrome/renderer/resources/extensions/schema_generated_bindings.js

Issue 10310182: Hack to restrict runtime API to dev channel rather than experimental. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: docs Created 8 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/renderer/resources/extensions/schema_generated_bindings.js
diff --git a/chrome/renderer/resources/extensions/schema_generated_bindings.js b/chrome/renderer/resources/extensions/schema_generated_bindings.js
index 66c193acac0d7f831b787cc5c8bcf9daa10f519a..12a4403686c4ee91a1cddfb9c6ee0168ef24a8d0 100644
--- a/chrome/renderer/resources/extensions/schema_generated_bindings.js
+++ b/chrome/renderer/resources/extensions/schema_generated_bindings.js
@@ -10,7 +10,7 @@
var GetExtensionAPIDefinition =
requireNative('apiDefinitions').GetExtensionAPIDefinition;
var sendRequest = require('sendRequest').sendRequest;
-
+ var isDevChannel = requireNative('channel').IsDevChannel;
var chromeHidden = requireNative('chrome_hidden').GetChromeHidden();
// The object to generate the bindings for "internal" APIs in, so that
@@ -341,9 +341,18 @@
manifestVersion <= schemaNode.maximumManifestVersion;
}
+ // Temporary hack to check if the runtime API is supported.
+ // TODO(aa): Remove when we can restrict non-permission APIs to dev-only.
+ function isRuntimeAPISupported(schemaNode) {
+ if (schemaNode.namespace == "runtime")
+ return isDevChannel();
+ return true;
+ }
+
function isSchemaNodeSupported(schemaNode, platform, manifestVersion) {
return isPlatformSupported(schemaNode, platform) &&
- isManifestVersionSupported(schemaNode, manifestVersion);
+ isManifestVersionSupported(schemaNode, manifestVersion) &&
+ isRuntimeAPISupported(schemaNode);
}
chromeHidden.onLoad.addListener(function(extensionId,

Powered by Google App Engine
This is Rietveld 408576698