Disable GPU info collection on GPU process startup on Win/Mac.

Disable GPU info collection on GPU process startup on Win/Mac.

This is because preliminary GPU info is enough for making final blacklist decisions on Win/Mac.

However, at the moment on Linux, blacklist decisions are still depending on full GPU info in certain cases, so we still need to do it on Linux.

The full GPU info collection is done on demand when about:gpu page opens.

Also, we need GPU's vendor_id, device_id, driver_version for crash reporting in GPU process.  So before about:gpu page opens, we won't have them.  Therefore, we pass them down from browser process to GPU process through commandline switches.

BUG=128082
TEST=about:gpu
R=apatrick
TBR=jam
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=137725

[Zhenyao Mo, 2012-05-15 23:08:17]

Al, please have a look.

[jochen (gone - plz use gerrit), 2012-05-16 07:34:18]

https://chromiumcodereview.appspot.com/10310180/diff/7001/content/gpu/gpu_chi...
File content/gpu/gpu_child_thread.cc (right):

https://chromiumcodereview.appspot.com/10310180/diff/7001/content/gpu/gpu_chi...
content/gpu/gpu_child_thread.cc:171: LOG(INFO) <<
"gpu_info_collector::CollectGraphicsInfo failed";
please use VLOG(1) instead of LOG(INFO)

[apatrick_chromium, 2012-05-16 18:02:35]

https://chromiumcodereview.appspot.com/10310180/diff/8003/content/gpu/gpu_chi...
File content/gpu/gpu_child_thread.cc (right):

https://chromiumcodereview.appspot.com/10310180/diff/8003/content/gpu/gpu_chi...
content/gpu/gpu_child_thread.cc:168: if (gfx::GLSurface::InitializeOneOff()) {
At this point, the GPU sandbox might have been turned on and this function will
sometimes fail on Windows. That's why it happens in GpuMain. Whether this will
work depends on whether this code runs in the "sandboxed" or "unsandboxed" GPU
process. Can you clarify which of the two this IPC handler will run in?

https://chromiumcodereview.appspot.com/10310180/diff/8003/content/gpu/gpu_chi...
content/gpu/gpu_child_thread.cc:170: if
(!gpu_info_collector::CollectGraphicsInfo(&gpu_info_)) {
.. ditto this.

https://chromiumcodereview.appspot.com/10310180/diff/8003/content/gpu/gpu_chi...
content/gpu/gpu_child_thread.cc:178: if (access("/dev/nvidiactl", R_OK) != 0) {
... and I suspect this might fail on Linux once the GPU sandbox is enabled on
Linux.

https://chromiumcodereview.appspot.com/10310180/diff/8003/content/gpu/gpu_mai...
File content/gpu/gpu_main.cc (left):

https://chromiumcodereview.appspot.com/10310180/diff/8003/content/gpu/gpu_mai...
content/gpu/gpu_main.cc:77: if (gfx::GLSurface::InitializeOneOff()) {
See remarkes for gpu_child_thread.cc first. I think, at a minimum, this line
needs to stay in GpuMain.

[Zhenyao Mo, 2012-05-17 18:29:40]

Revised, please have a look.

Now:

on Linux:  collect full GPU info on startup
On Mac/Win: pass key GPU info from browser to GPU.  collect GPU full info only
when about:gpu is open.

[apatrick_chromium, 2012-05-17 18:44:39]

Have you tested it with --single-process as well?

http://codereview.chromium.org/10310180/diff/13003/content/browser/gpu/gpu_da...
File content/browser/gpu/gpu_data_manager_impl.cc (right):

http://codereview.chromium.org/10310180/diff/13003/content/browser/gpu/gpu_da...
content/browser/gpu/gpu_data_manager_impl.cc:223:
command_line->AppendSwitchASCII(switches::kGpuVendorID,
I think these need to be added to the list of propagated switches in
GpuProcessHost::LaunchGpuProcess

http://codereview.chromium.org/10310180/diff/13003/ui/gl/gl_switches.h
File ui/gl/gl_switches.h (right):

http://codereview.chromium.org/10310180/diff/13003/ui/gl/gl_switches.h#newcode31
ui/gl/gl_switches.h:31: GL_EXPORT extern const char kGpuDeviceID[];
I think these should be in content_switches.h

[Zhenyao Mo, 2012-05-17 19:58:40]

Tested with --single-process with webgl aquarium and it works (on Mac)

Please have another look.

http://codereview.chromium.org/10310180/diff/13003/content/browser/gpu/gpu_da...
File content/browser/gpu/gpu_data_manager_impl.cc (right):

http://codereview.chromium.org/10310180/diff/13003/content/browser/gpu/gpu_da...
content/browser/gpu/gpu_data_manager_impl.cc:223:
command_line->AppendSwitchASCII(switches::kGpuVendorID,
On 2012/05/17 18:44:40, apatrick_chromium wrote:
> I think these need to be added to the list of propagated switches in
> GpuProcessHost::LaunchGpuProcess

Not really.  I didn't add them to browser process's switches.  I directly insert
them for GPU process.

http://codereview.chromium.org/10310180/diff/13003/ui/gl/gl_switches.h
File ui/gl/gl_switches.h (right):

http://codereview.chromium.org/10310180/diff/13003/ui/gl/gl_switches.h#newcode31
ui/gl/gl_switches.h:31: GL_EXPORT extern const char kGpuDeviceID[];
On 2012/05/17 18:44:40, apatrick_chromium wrote:
> I think these should be in content_switches.h

Done.

[apatrick_chromium, 2012-05-17 20:14:22]

lgtm