Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2485)

Unified Diff: chrome/browser/sync/profile_sync_service_autofill_unittest.cc

Issue 10310113: Add additional error logging to investigate Autocomplete Sync failures. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: De-nitting Created 8 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/sync/profile_sync_service_autofill_unittest.cc
diff --git a/chrome/browser/sync/profile_sync_service_autofill_unittest.cc b/chrome/browser/sync/profile_sync_service_autofill_unittest.cc
index 2e42c1722d1eee234142c2b974d32270ad1ab716..12126d0b2d94e24230aeb2ad9d82dd9523eca93f 100644
--- a/chrome/browser/sync/profile_sync_service_autofill_unittest.cc
+++ b/chrome/browser/sync/profile_sync_service_autofill_unittest.cc
@@ -460,7 +460,9 @@ class ProfileSyncServiceAutofillTest : public AbstractProfileSyncServiceTest {
sync_api::WriteNode node(&trans);
std::string tag = AutocompleteSyncableService::KeyToTag(
UTF16ToUTF8(entry.key().name()), UTF16ToUTF8(entry.key().value()));
- if (!node.InitUniqueByCreation(syncable::AUTOFILL, autofill_root, tag))
+ sync_api::WriteNode::InitUniqueByCreationResult result =
+ node.InitUniqueByCreation(syncable::AUTOFILL, autofill_root, tag);
+ if (result != sync_api::WriteNode::INIT_SUCCESS)
return false;
sync_pb::EntitySpecifics specifics;
@@ -480,9 +482,12 @@ class ProfileSyncServiceAutofillTest : public AbstractProfileSyncServiceTest {
}
sync_api::WriteNode node(&trans);
std::string tag = profile.guid();
- if (!node.InitUniqueByCreation(syncable::AUTOFILL_PROFILE,
- autofill_root, tag))
+ sync_api::WriteNode::InitUniqueByCreationResult result =
+ node.InitUniqueByCreation(syncable::AUTOFILL_PROFILE,
+ autofill_root, tag);
+ if (result != sync_api::WriteNode::INIT_SUCCESS)
return false;
+
sync_pb::EntitySpecifics specifics;
AutofillProfileSyncableService::WriteAutofillProfile(profile, &specifics);
sync_pb::AutofillProfileSpecifics* profile_specifics =
« no previous file with comments | « chrome/browser/sync/glue/typed_url_model_associator.cc ('k') | chrome/browser/sync/profile_sync_service_password_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698